Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 7273026: Fix bug in register assignment of IsObjectAndBranch. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
1091 HIsNull* compare = HIsNull::cast(v); 1091 HIsNull* compare = HIsNull::cast(v);
1092 ASSERT(compare->value()->representation().IsTagged()); 1092 ASSERT(compare->value()->representation().IsTagged());
1093 // We only need a temp register for non-strict compare. 1093 // We only need a temp register for non-strict compare.
1094 LOperand* temp = compare->is_strict() ? NULL : TempRegister(); 1094 LOperand* temp = compare->is_strict() ? NULL : TempRegister();
1095 return new LIsNullAndBranch(UseRegisterAtStart(compare->value()), temp); 1095 return new LIsNullAndBranch(UseRegisterAtStart(compare->value()), temp);
1096 } else if (v->IsIsObject()) { 1096 } else if (v->IsIsObject()) {
1097 HIsObject* compare = HIsObject::cast(v); 1097 HIsObject* compare = HIsObject::cast(v);
1098 ASSERT(compare->value()->representation().IsTagged()); 1098 ASSERT(compare->value()->representation().IsTagged());
1099 LOperand* temp1 = TempRegister(); 1099 LOperand* temp1 = TempRegister();
1100 LOperand* temp2 = TempRegister(); 1100 LOperand* temp2 = TempRegister();
1101 return new LIsObjectAndBranch(UseRegisterAtStart(compare->value()), 1101 return new LIsObjectAndBranch(UseRegister(compare->value()),
1102 temp1, 1102 temp1,
1103 temp2); 1103 temp2);
1104 } else if (v->IsCompareObjectEq()) { 1104 } else if (v->IsCompareObjectEq()) {
1105 HCompareObjectEq* compare = HCompareObjectEq::cast(v); 1105 HCompareObjectEq* compare = HCompareObjectEq::cast(v);
1106 return new LCmpObjectEqAndBranch(UseRegisterAtStart(compare->left()), 1106 return new LCmpObjectEqAndBranch(UseRegisterAtStart(compare->left()),
1107 UseRegisterAtStart(compare->right())); 1107 UseRegisterAtStart(compare->right()));
1108 } else if (v->IsCompareConstantEq()) { 1108 } else if (v->IsCompareConstantEq()) {
1109 HCompareConstantEq* compare = HCompareConstantEq::cast(v); 1109 HCompareConstantEq* compare = HCompareConstantEq::cast(v);
1110 return new LCmpConstantEqAndBranch(UseRegisterAtStart(compare->value())); 1110 return new LCmpConstantEqAndBranch(UseRegisterAtStart(compare->value()));
1111 } else if (v->IsTypeofIs()) { 1111 } else if (v->IsTypeofIs()) {
(...skipping 1175 matching lines...) Expand 10 before | Expand all | Expand 10 after
2287 LOperand* key = UseOrConstantAtStart(instr->key()); 2287 LOperand* key = UseOrConstantAtStart(instr->key());
2288 LOperand* object = UseOrConstantAtStart(instr->object()); 2288 LOperand* object = UseOrConstantAtStart(instr->object());
2289 LIn* result = new LIn(key, object); 2289 LIn* result = new LIn(key, object);
2290 return MarkAsCall(DefineFixed(result, eax), instr); 2290 return MarkAsCall(DefineFixed(result, eax), instr);
2291 } 2291 }
2292 2292
2293 2293
2294 } } // namespace v8::internal 2294 } } // namespace v8::internal
2295 2295
2296 #endif // V8_TARGET_ARCH_IA32 2296 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698