Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 7273026: Fix bug in register assignment of IsObjectAndBranch. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
1091 return new LHasCachedArrayIndexAndBranch( 1091 return new LHasCachedArrayIndexAndBranch(
1092 UseRegisterAtStart(compare->value())); 1092 UseRegisterAtStart(compare->value()));
1093 } else if (v->IsIsNull()) { 1093 } else if (v->IsIsNull()) {
1094 HIsNull* compare = HIsNull::cast(v); 1094 HIsNull* compare = HIsNull::cast(v);
1095 ASSERT(compare->value()->representation().IsTagged()); 1095 ASSERT(compare->value()->representation().IsTagged());
1096 return new LIsNullAndBranch(UseRegisterAtStart(compare->value())); 1096 return new LIsNullAndBranch(UseRegisterAtStart(compare->value()));
1097 } else if (v->IsIsObject()) { 1097 } else if (v->IsIsObject()) {
1098 HIsObject* compare = HIsObject::cast(v); 1098 HIsObject* compare = HIsObject::cast(v);
1099 ASSERT(compare->value()->representation().IsTagged()); 1099 ASSERT(compare->value()->representation().IsTagged());
1100 LOperand* temp = TempRegister(); 1100 LOperand* temp = TempRegister();
1101 return new LIsObjectAndBranch(UseRegisterAtStart(compare->value()), temp); 1101 return new LIsObjectAndBranch(UseRegister(compare->value()), temp);
1102 } else if (v->IsCompareObjectEq()) { 1102 } else if (v->IsCompareObjectEq()) {
1103 HCompareObjectEq* compare = HCompareObjectEq::cast(v); 1103 HCompareObjectEq* compare = HCompareObjectEq::cast(v);
1104 return new LCmpObjectEqAndBranch(UseRegisterAtStart(compare->left()), 1104 return new LCmpObjectEqAndBranch(UseRegisterAtStart(compare->left()),
1105 UseRegisterAtStart(compare->right())); 1105 UseRegisterAtStart(compare->right()));
1106 } else if (v->IsCompareConstantEq()) { 1106 } else if (v->IsCompareConstantEq()) {
1107 HCompareConstantEq* compare = HCompareConstantEq::cast(v); 1107 HCompareConstantEq* compare = HCompareConstantEq::cast(v);
1108 return new LCmpConstantEqAndBranch(UseRegisterAtStart(compare->value())); 1108 return new LCmpConstantEqAndBranch(UseRegisterAtStart(compare->value()));
1109 } else if (v->IsTypeofIs()) { 1109 } else if (v->IsTypeofIs()) {
1110 HTypeofIs* typeof_is = HTypeofIs::cast(v); 1110 HTypeofIs* typeof_is = HTypeofIs::cast(v);
1111 return new LTypeofIsAndBranch(UseTempRegister(typeof_is->value())); 1111 return new LTypeofIsAndBranch(UseTempRegister(typeof_is->value()));
(...skipping 1123 matching lines...) Expand 10 before | Expand all | Expand 10 after
2235 2235
2236 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2236 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2237 LOperand* key = UseRegisterAtStart(instr->key()); 2237 LOperand* key = UseRegisterAtStart(instr->key());
2238 LOperand* object = UseRegisterAtStart(instr->object()); 2238 LOperand* object = UseRegisterAtStart(instr->object());
2239 LIn* result = new LIn(key, object); 2239 LIn* result = new LIn(key, object);
2240 return MarkAsCall(DefineFixed(result, r0), instr); 2240 return MarkAsCall(DefineFixed(result, r0), instr);
2241 } 2241 }
2242 2242
2243 2243
2244 } } // namespace v8::internal 2244 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698