Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 7273019: Fix a Chrome browser crash which is seen during chrome frame reliability test runs.Based on the c... (Closed)

Created:
9 years, 6 months ago by ananta
Modified:
9 years, 5 months ago
Reviewers:
robertshield
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix a Chrome browser crash which is seen during chrome frame reliability test runs.Based on the callstack it occurs when the cookie completion callback map's singleton instance is torn down during shutdown. It looks like there are unprocessed cookie request entries in the map which when deleted by the map destructor cause a crash. Fix being attempted is to delete the cookie entries associated with the AutomationResourceMessageFilter instance when we receive an OnChannelClosing notification. Fixes bug http://code.google.com/p/chromium/issues/detail?id=87693 BUG=87693 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90811

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/automation/automation_resource_message_filter.cc View 3 chunks +15 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 6 months ago (2011-06-28 00:29:30 UTC) #1
robertshield
9 years, 5 months ago (2011-06-28 18:28:35 UTC) #2
LGTM, just one nit:

http://codereview.chromium.org/7273019/diff/1/chrome/browser/automation/autom...
File chrome/browser/automation/automation_resource_message_filter.cc (right):

http://codereview.chromium.org/7273019/diff/1/chrome/browser/automation/autom...
chrome/browser/automation/automation_resource_message_filter.cc:170: } else {
drop the else and increment callback_index only in a single location?

Powered by Google App Engine
This is Rietveld 408576698