Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7272043: Update Lexer/Parser to support '#inline' and 'label' (Closed)

Created:
9 years, 5 months ago by noelallen1
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update Lexer/Parser to support '#inline' and 'label' Added the keyword 'label' to support versioning. Added the token INLINE to capture blocks of text within #inline XXX #endinl Updated tests TEST= python idl_lexer.py --test && python idl_parser.py --test BUG= http://code.google.com/p/chromium/issues/detail?id=87684 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91426

Patch Set 1 #

Total comments: 14

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -215 lines) Patch
M ppapi/generators/idl_lexer.py View 1 6 chunks +50 lines, -7 lines 0 comments Download
M ppapi/generators/idl_parser.py View 1 2 26 chunks +304 lines, -170 lines 0 comments Download
M ppapi/generators/test_cgen/interface.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/generators/test_cgen/structs.idl View 1 chunk +14 lines, -0 lines 0 comments Download
M ppapi/generators/test_lex.in View 1 2 chunks +30 lines, -11 lines 0 comments Download
M ppapi/generators/test_namespace/foo.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/generators/test_parser/enum.idl View 2 chunks +16 lines, -2 lines 0 comments Download
M ppapi/generators/test_parser/interface.idl View 3 chunks +10 lines, -10 lines 0 comments Download
M ppapi/generators/test_parser/struct.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/generators/test_parser/typedef.idl View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
9 years, 5 months ago (2011-06-28 23:44:41 UTC) #1
sehr (please use chromium)
A few small issues. One request for a clarification. http://codereview.chromium.org/7272043/diff/1/ppapi/generators/idl_lexer.py File ppapi/generators/idl_lexer.py (right): http://codereview.chromium.org/7272043/diff/1/ppapi/generators/idl_lexer.py#newcode49 ppapi/generators/idl_lexer.py:49: ...
9 years, 5 months ago (2011-06-29 16:43:06 UTC) #2
noelallen1
9 years, 5 months ago (2011-06-29 18:29:33 UTC) #3
noelallen1
PTAL Multi-line/word testing for comments was broken in the lexer because of the way I ...
9 years, 5 months ago (2011-06-29 18:59:01 UTC) #4
noelallen1
9 years, 5 months ago (2011-07-01 08:33:11 UTC) #5
sehr (please use chromium)
9 years, 5 months ago (2011-07-01 22:59:22 UTC) #6
On 2011/07/01 08:33:11, noelallen1 wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698