Make MediaInternalsUI talk to MediaInternals.

chrome/browser/ui/webui/media_internals_proxy.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_MEDIA_INTERNALS_PROXY_H_
+#define CHROME_BROWSER_UI_WEBUI_MEDIA_INTERNALS_PROXY_H_
+#pragma once
+
+#include "base/memory/ref_counted.h"
+#include "base/string16.h"
+#include "chrome/browser/media/media_internals_observer.h"
+
+class IOThread;
+class MediaInternalsUI;
+
+class MediaInternalsProxy
+    : public MediaInternalsObserver,

[scherkus (not reviewing), 2011/06/29 17:55:12]

docs for class

[Scott Franklin, 2011/06/29 18:44:33]

Done.

+      public base::RefCountedThreadSafe<MediaInternalsProxy> {
+ public:
+  // Methods for MediaInternalsUI. Called on UI thread.
+  MediaInternalsProxy();

[scherkus (not reviewing), 2011/06/29 17:55:12]

nit: typically have a blank line between the ctor/dtor section + methods

[Scott Franklin, 2011/06/29 18:44:33]

Done.

+  void SetUI(MediaInternalsUI* ui);

[scherkus (not reviewing), 2011/06/29 17:55:12]

why not not pass in the ui in the ctor?

then instead of RemoveUI() you can name it Detach() or similar

[Scott Franklin, 2011/06/29 18:44:33]

I can't call PostTask in the ctor (which makes sense; wouldn't want tasks
operating on a partially-constructed object).

+  void RemoveUI();
+  void GetEverything();

[scherkus (not reviewing), 2011/06/29 17:55:12]

docs for non-interface-implementation methods

[Scott Franklin, 2011/06/29 18:44:33]

Done.

+
+  // MediaInternalsObserver implementation. Called on IO thread.
+  virtual void OnUpdate(const string16& update);
+
+ private:
+  friend class base::RefCountedThreadSafe<MediaInternalsProxy>;
+  virtual ~MediaInternalsProxy();
+
+  void ObserveMediaInternalsOnIOThread();
+  void StopObservingMediaInternalsOnIOThread();
+  void GetEverythingOnIOThread();
+  void UpdateUIOnUIThread(const string16& update);
+
+  MediaInternalsUI* ui_;
+  IOThread* io_thread_;
+};

[scherkus (not reviewing), 2011/06/29 17:55:12]

DISALLOW etc

[Scott Franklin, 2011/06/29 18:44:33]

Done.

+
+#endif  // CHROME_BROWSER_UI_WEBUI_MEDIA_INTERNALS_PROXY_H_