Fix regression: Download status doesn't appear anymore in the download-shelf

Fix regression: Download status doesn't appear anymore in the download-shelf

Caused by http://codereview.chromium.org/6905049

Replaced show/hideStatusAnimation_ with toggleStatusVisibilityAnimation_
because show/hideStatusAnimation_ shouldn't exist at the same time. 

BUG=86640
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91492

[keishi1, 2011-07-04 09:31:16]

Moved patch to my google.com account

[Nico, 2011-07-04 16:39:02]

Thank you very much for the test!

LGTM with NSLog() calls removed, : alignment fixed, and if possible a new helper
function added. (You can just submit once you've done that, no need for another
round.)

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
File chrome/browser/ui/cocoa/download/download_item_cell.mm (right):

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:609: // No core animation
-- text in CA layers is not subpixel antialiased :-/
Can you s/No/Don't use/?

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:613:
animationCurve:NSAnimationEaseIn]);
ObjC style is to align the colons (:) vertically – see the left side of this
diff.

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:616: NSLog(@"start");
Remove

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:620: -
(void)hideSecondaryTitle {
From what I can tell, this function is identical to the previous one except for
the first 3 lines. Can you factor the common part into a new function?

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:632: // No core animation
-- text in CA layers is not subpixel antialiased :-/
here too

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:636:
animationCurve:NSAnimationEaseIn]);
align : too

http://codereview.chromium.org/7272024/diff/2001/chrome/browser/ui/cocoa/down...
chrome/browser/ui/cocoa/download/download_item_cell.mm:644: NSLog(@"progress");
remove

[Randy Smith (Not in Mondays), 2011-07-05 00:49:21]

LGTM, but that's mostly based on thakis' ok--I skimmed it and it looked fine,
but I don't know this code well.

[commit-bot: I haz the power, 2011-07-05 08:32:59]

Change committed as 91492