Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 7272005: Do not record extension install histograms for upgrades. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index a8973f6ee595538c265252072264ae98867c28f8..4bc2c208f09e84ee4e9a45d590a8bb3183fc7019 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2055,10 +2055,14 @@ void ExtensionService::OnExtensionInstalled(const Extension* extension) {
}
}
- UMA_HISTOGRAM_ENUMERATION("Extensions.InstallType",
- extension->GetType(), 100);
- RecordPermissionMessagesHistogram(
- extension, "Extensions.Permissions_Install");
+ // Do not record the install histograms for upgrades.
+ if (!GetExtensionByIdInternal(extension->id(), true, true, false)) {
+ UMA_HISTOGRAM_ENUMERATION("Extensions.InstallType",
+ extension->GetType(), 100);
+ RecordPermissionMessagesHistogram(
+ extension, "Extensions.Permissions_Install");
+ }
+
ShownSectionsHandler::OnExtensionInstalled(profile_->GetPrefs(), extension);
extension_prefs_->OnExtensionInstalled(
extension, initial_enable ? Extension::ENABLED : Extension::DISABLED);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698