Issue 7272002: Cleanup to HEnvironment::CopyForInlining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7272002: Cleanup to HEnvironment::CopyForInlining (Closed)

Created:
9 years, 6 months ago by wingo

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup to HEnvironment::CopyForInlining * src/hydrogen.cc (HEnvironment::CopyForInlining): As the code for both the ::HYDROGEN and ::LITHIUM compilation phases is the same, just use one code path and remove the arg. * src/hydrogen.h (HEnvironment): Remove now-unused CompilationPhase enum type and arg to CopyForInlining. * src/arm/lithium-arm.cc (LChunkBuilder::DoEnterInlined): * src/ia32/lithium-ia32.cc (LChunkBuilder::DoEnterInlined): * src/x64/lithium-x64.cc (LChunkBuilder::DoEnterInlined): Adapt callers. * AUTHORS: Add Igalia. BUG= TEST=I ran tools/test.py. Committed: http://code.google.com/p/v8/source/detail?r=8442

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -22 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/hydrogen.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+3 lines, -13 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wingo

Added reviewers. Hopefully this doesn't send a duplicate mail.

9 years, 6 months ago (2011-06-27 15:28:47 UTC) #1

LGTM, I'll land.

Expand Messages | Collapse Messages