Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 7269003: Change grit to depend on test data in the main repository. (Closed)

Created:
9 years, 5 months ago by Jói
Modified:
9 years, 5 months ago
Reviewers:
tony
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Change grit to depend on test data in the main repository. BUG=82636 TEST=python tools/grit/grit.py unit Initial commit r91161, turned three bots red. Reverted r91165. Investigation shows only clobber is needed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6437 lines, -43 lines) Patch
M tools/grit/grit/clique_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/grit/grit/format/rc_unittest.py View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/grit/grit/gather/admin_template_unittest.py View 6 chunks +8 lines, -9 lines 0 comments Download
M tools/grit/grit/gather/rc_unittest.py View 3 chunks +6 lines, -4 lines 0 comments Download
M tools/grit/grit/gather/tr_html_unittest.py View 7 chunks +6 lines, -7 lines 0 comments Download
M tools/grit/grit/grd_reader_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/grit/grit_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/grit/node/io_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/grit/grit/node/misc_unittest.py View 3 chunks +4 lines, -5 lines 0 comments Download
A tools/grit/grit/testdata/GoogleDesktop.adm View 1 chunk +945 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/README.txt View 1 chunk +87 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/about.html View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/bad_browser.html View 1 chunk +16 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/browser.html View 1 chunk +42 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/cache_prefix.html View 1 chunk +24 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/cache_prefix_file.html View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/chat_result.html View 1 chunk +24 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/del_footer.html View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/del_header.html View 1 chunk +60 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/deleted.html View 1 chunk +21 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/details.html View 1 chunk +10 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/duplicate-name-input.xml View 1 chunk +26 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/email_result.html View 1 chunk +34 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/email_thread.html View 1 chunk +10 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/error.html View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/explicit_web.html View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/footer.html View 1 chunk +14 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/generated_resources_fr.xtb View 1 chunk +3090 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/header.html View 1 chunk +39 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/homepage.html View 1 chunk +37 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/hover.html View 1 chunk +177 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/include_test.html View 1 chunk +31 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/included_sample.html View 1 chunk +1 line, -0 lines 0 comments Download
A tools/grit/grit/testdata/indexing_speed.html View 1 chunk +58 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/install_prefs.html View 1 chunk +92 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/install_prefs2.html View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/klonk.ico View Binary file 0 comments Download
A tools/grit/grit/testdata/klonk.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/grit/grit/testdata/klonk-alternate-skeleton.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/grit/grit/testdata/ko_oem_enable_bug.html View 1 chunk +1 line, -0 lines 0 comments Download
A tools/grit/grit/testdata/ko_oem_non_admin_bug.html View 1 chunk +1 line, -0 lines 0 comments Download
A tools/grit/grit/testdata/mini.html View 1 chunk +36 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/oem_enable.html View 1 chunk +106 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/oem_non_admin.html View 1 chunk +39 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/onebox.html View 1 chunk +21 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/oneclick.html View 1 chunk +34 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/password.html View 1 chunk +37 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/preferences.html View 1 chunk +234 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/privacy.html View 1 chunk +35 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/quit_apps.html View 1 chunk +49 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/recrawl.html View 1 chunk +30 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/resource_ids View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/script.html View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/searchbox.html View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/sidebar_h.html View 1 chunk +82 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/sidebar_v.html View 1 chunk +267 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/simple.html View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/simple-input.xml View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/source.rc View 1 chunk +57 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/status.html View 1 chunk +44 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/time_related.html View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/toolbar_about.html View 1 chunk +138 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/transl.rc View 1 chunk +56 lines, -0 lines 0 comments Download
A tools/grit/grit/testdata/versions.html View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/grit/grit/tool/transl2tc_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/grit/grit/xtb_reader_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
9 years, 5 months ago (2011-06-30 15:25:00 UTC) #1
tony
9 years, 5 months ago (2011-06-30 17:49:21 UTC) #2
Awesome! LGTM (I didn't look at the data files, but the python changes all LG).

Powered by Google App Engine
This is Rietveld 408576698