Readability review for gfeher

chrome/browser/policy/logging_work_scheduler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/logging_work_scheduler.h"
 
 #include <algorithm>
 
 #include "base/compiler_specific.h"
 #include "content/browser/browser_thread.h"
 
 namespace policy {
 
+// Objects of this class are used in the priority-queue of future tasks
+// in EventLogger.
+class EventLogger::Task {
+ public:
+  Task();
+  Task(int64 trigger_time,
+       int64 secondary_key,
+       linked_ptr<base::Closure> callback);
+  ~Task();
+
+  // Returns true if |this| should be executed before |rhs|.
+  // Used for sorting by the priority queue.
+  bool operator< (const Task& rhs) const;
+
+  int64 trigger_time() const;
+
+  // Returns a copy of the callback object of this task, and resets the
+  // original callback object. (LoggingTaskScheduler owns a linked_ptr to
+  // its task's callback objects and it only allows firing new tasks if the
+  // previous task's callback object has been reset.)
+  base::Closure GetAndResetCallback();
+
+ private:
+  // The virtual time when this task will trigger.
+  // Smaller times win.
+  int64 trigger_time_;
+  // Used for sorting tasks that have the same trigger_time.
+  // Bigger keys win.
+  int64 secondary_key_;
+
+  linked_ptr<base::Closure> callback_;
+};
+
 EventLogger::Task::Task() {
 }
 
 EventLogger::Task::Task(int64 trigger_time,
                         int64 secondary_key,
                         linked_ptr<base::Closure> callback)
     : trigger_time_(trigger_time),
       secondary_key_(secondary_key),
       callback_(callback) {
 }
@@ skipping 117 matching lines @@
   logger_->PostDelayedWork(callback_, delay);
 }
 
 void LoggingWorkScheduler::CancelDelayedWork() {
   if (!callback_.get()) return;
   callback_->Reset();  // Erase the callback to the delayed work.
   callback_.reset(NULL);  // Erase the pointer to the callback.
 }
 
 }  // namespace policy