views/ime/character_composer_unittest.cc - Issue 7264015: CL for readability review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: views/ime/character_composer_unittest.cc

Issue 7264015: CL for readability review (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« views/ime/character_composer.cc ('K') | « views/ime/character_composer.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "views/ime/character_composer.h"	5 #include "views/ime/character_composer.h"

6	6

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8 #include "third_party/gtk+/gdk/gdkkeysyms.h"	8 #include "third_party/gtk+/gdk/gdkkeysyms.h"

9	9

10 namespace views {	10 namespace views {

(...skipping 129 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
140 CharacterComposer character_composer;	140 CharacterComposer character_composer;

141 // Even though sequence ['dead acute', 'a'] will compose 'a with acute',	141 // Even though sequence ['dead acute', 'a'] will compose 'a with acute',

142 // no character is composed here because of reset.	142 // no character is composed here because of reset.

143 ExpectKeyFiltered(&character_composer, GDK_KEY_dead_acute);	143 ExpectKeyFiltered(&character_composer, GDK_KEY_dead_acute);

144 character_composer.Reset();	144 character_composer.Reset();

145 EXPECT_FALSE(character_composer.FilterKeyPress(GDK_KEY_a));	145 EXPECT_FALSE(character_composer.FilterKeyPress(GDK_KEY_a));

146 EXPECT_TRUE(character_composer.GetComposedCharacter().empty());	146 EXPECT_TRUE(character_composer.GetComposedCharacter().empty());

147 }	147 }

148	148

149 } // namespace views	149 } // namespace views

	150 //

OLD	NEW