Gmail mails get modified upon send due to certain extensions

Gmail mails get modified upon send due to certain extensions

Recently, we changed most code to use the Document URL instead of the
DataSource URL to decide how to treat frames. Generally, the Document URL is
the "one true URL" for the document. However, this change broke some extensions
that were not expecting their content scripts to be injected into some iframes,
such as the compose iframe used by Gmail. Gmail creates the iframe with a URL
of about:blank but then document.write()s into the iframe, changing the URL of
the document. This patch restores the old behavior for the user script slave to
maintain compatibility with these extensions.

BUG=86742
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91180

[abarth-chromium, 2011-06-26 20:33:26]

@mihaip: Feel free to bounce this review to someone else if they'd be more
appropriate.

[Mihai Parparita -not on Chrome, 2011-06-28 00:38:23]

http://codereview.chromium.org/7264014/diff/1/chrome/test/data/extensions/api...
File
chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.html
(right):

http://codereview.chromium.org/7264014/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.html:2:
chrome.test.runTests([
It seems like this test could be flaky, since there's no explicit guarantee that
the onRequest handler is installed before the tab is created. Other tests
generally follow this pattern:

chrome.test.getConfig(function(config) {
  chrome.test.runTests([
    function onRequest() {
      chrome.extension.onRequest.addListener(...)
      chrome.tabs.create(...)
    }
  ]);
});

[abarth-chromium, 2011-06-28 00:45:32]

Ok.  I used another test as a template (something else in this same folder). 
Perhaps that test is flaky as well.

[Mihai Parparita -not on Chrome, 2011-06-28 00:55:11]

On Mon, Jun 27, 2011 at 5:45 PM,  <abarth@chromium.org> wrote:
> Ok.  I used another test as a template (something else in this same folder).
> Perhaps that test is flaky as well.

Out of curiosity, which test was it?

Mihai

[abarth-chromium, 2011-06-28 01:03:11]

On Mon, Jun 27, 2011 at 5:55 PM, Mihai Parparita <mihaip@chromium.org> wrote:
> On Mon, Jun 27, 2011 at 5:45 PM,  <abarth@chromium.org> wrote:
>> Ok.  I used another test as a template (something else in this same folder).
>> Perhaps that test is flaky as well.
>
> Out of curiosity, which test was it?

I don't remember, but I'll figure that out when this comes back to the
top of my list.

Adam

[abarth-chromium, 2011-06-30 07:45:55]

> Out of curiosity, which test was it?

extensions/api_test/content_scripts/all_frames

/me is trying the re-organization now.

[abarth-chromium, 2011-06-30 08:45:14]

Test fixenated.  Please take another look.  Thanks!

[Mihai Parparita -not on Chrome, 2011-06-30 18:37:08]

LGTM

[abarth-chromium, 2011-06-30 18:41:47]

On 2011/06/30 18:37:08, Mihai Parparita wrote:
> LGTM

Thanks!

[commit-bot: I haz the power, 2011-06-30 18:41:55]

Presubmit check for 7264014-8002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
 
chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/content_script.js

[abarth-chromium, 2011-06-30 18:43:16]

It's very important that we copyright that script.  Please hold.

[commit-bot: I haz the power, 2011-06-30 19:50:08]

Change committed as 91180