Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: src/codegen-ia32.cc

Issue 7264: Fix lint error in codegen-ia32.cc. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2111 } 2111 }
2112 __ Set(ecx, Immediate(Smi::FromInt(JUMPING + i))); 2112 __ Set(ecx, Immediate(Smi::FromInt(JUMPING + i)));
2113 __ jmp(&unlink); 2113 __ jmp(&unlink);
2114 } 2114 }
2115 } 2115 }
2116 2116
2117 // Unlink from try chain; be careful not to destroy the TOS. 2117 // Unlink from try chain; be careful not to destroy the TOS.
2118 __ bind(&unlink); 2118 __ bind(&unlink);
2119 // Reload sp from the top handler, because some statements that we 2119 // Reload sp from the top handler, because some statements that we
2120 // break from (eg, for...in) may have left stuff on the stack. 2120 // break from (eg, for...in) may have left stuff on the stack.
2121 frame_->Pop(eax); // preserve the TOS in a register across stack manipulation 2121 // Preserve the TOS in a register across stack manipulation.
2122 frame_->Pop(eax);
2122 ExternalReference handler_address(Top::k_handler_address); 2123 ExternalReference handler_address(Top::k_handler_address);
2123 __ mov(edx, Operand::StaticVariable(handler_address)); 2124 __ mov(edx, Operand::StaticVariable(handler_address));
2124 const int kNextOffset = StackHandlerConstants::kNextOffset + 2125 const int kNextOffset = StackHandlerConstants::kNextOffset +
2125 StackHandlerConstants::kAddressDisplacement; 2126 StackHandlerConstants::kAddressDisplacement;
2126 __ lea(esp, Operand(edx, kNextOffset)); 2127 __ lea(esp, Operand(edx, kNextOffset));
2127 2128
2128 frame_->Pop(Operand::StaticVariable(handler_address)); 2129 frame_->Pop(Operand::StaticVariable(handler_address));
2129 frame_->Drop(StackHandlerConstants::kSize / kPointerSize - 1); 2130 frame_->Drop(StackHandlerConstants::kSize / kPointerSize - 1);
2130 // next_sp popped. 2131 // Next_sp popped.
2131 frame_->Push(eax); // preserve the TOS in a register across stack manipulatio n 2132 // Preserve the TOS in a register across stack manipulation.
2133 frame_->Push(eax);
2132 2134
2133 // --- Finally block --- 2135 // --- Finally block ---
2134 __ bind(&finally_block); 2136 __ bind(&finally_block);
2135 2137
2136 // Push the state on the stack. 2138 // Push the state on the stack.
2137 frame_->Push(ecx); 2139 frame_->Push(ecx);
2138 2140
2139 // We keep two elements on the stack - the (possibly faked) result 2141 // We keep two elements on the stack - the (possibly faked) result
2140 // and the state - while evaluating the finally block. Record it, so 2142 // and the state - while evaluating the finally block. Record it, so
2141 // that a break/continue crossing this statement can restore the 2143 // that a break/continue crossing this statement can restore the
(...skipping 2967 matching lines...) Expand 10 before | Expand all | Expand 10 after
5109 5111
5110 // Slow-case: Go through the JavaScript implementation. 5112 // Slow-case: Go through the JavaScript implementation.
5111 __ bind(&slow); 5113 __ bind(&slow);
5112 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION); 5114 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION);
5113 } 5115 }
5114 5116
5115 5117
5116 #undef __ 5118 #undef __
5117 5119
5118 } } // namespace v8::internal 5120 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698