Issue 7263008: Fixup error message shown when Chromoting is not enabled properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7263008: Fixup error message shown when Chromoting is not enabled properly. (Closed)

Created:
9 years, 6 months ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
dmac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixup error message shown when Chromoting is not enabled properly. Previously, we did a version check first, so if the plugin didn't load we would display an (inappropriate) "version mis-match, please upgrade" message. This was very frustrating since it often happened immediately after installation, when the user was trying to use Remoting for the first time. This change checks the plugin status first and (if there's a problem) directs the user to verify that the 'Remoting' and 'P2P API' flags are enabled. This partially addresses bug 87282, but we still need to make this look prettier. BUG=87282 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90626

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	remoting/webapp/me2mom/remoting_session.js	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages