Implement proper synchronization between HW video decode IPC and CommandBuffer.

gpu/command_buffer/common/command_buffer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_COMMON_COMMAND_BUFFER_H_
 #define GPU_COMMAND_BUFFER_COMMON_COMMAND_BUFFER_H_
 
 #include "../common/buffer.h"
 #include "../common/constants.h"
 
@@ skipping 105 matching lines @@
   // Allows the reader to update the current token value.
   virtual void SetToken(int32 token) = 0;
 
   // Allows the reader to set the current parse error.
   virtual void SetParseError(error::Error) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CommandBuffer);
 };
 
+// Synchronizing other mechanisms (such as IPC) with the CommandBuffer requires
+// inserting (writing) a token into the buffer and knowing what the last token
+// read at that point was.  ReadWriteTokens is a convenience struct for passing
+// these pairs around.  Expected usage is to compare a current token to
+// [last_token_read,last_token_written).
+struct ReadWriteTokens {
+  ReadWriteTokens(int32 read, int32 written);
+  // Required to support pickling.  Use by anything else will DCHECK in InRange.
+  ReadWriteTokens();
+
+  // Return true iff |value| is in the range described by |tokens|, accounting
+  // for (up to) one wrap-around.
+  bool InRange(int32 token) const;
+
+  // This want to be private (and const) but can't in order to support pickling.

[piman, 2011/06/28 21:24:41]

No need for this comment... coding style says that structs should have public
members. This seems perfectly fair to be public.

[Ami GONE FROM CHROMIUM, 2011/06/28 21:27:38]

My reason for the comment is that this isn't used as a struct - nobody outside
this class other than pickle code should be reading or writing these members;
instead they should be using InRange().

+  int32 last_token_read;
+  int32 last_token_written;
+};
+
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_COMMON_COMMAND_BUFFER_H_