Implement proper synchronization between HW video decode IPC and CommandBuffer.

content/renderer/gpu/gpu_video_service_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/gpu_video_service_host.h"
 
 #include "content/common/gpu/gpu_messages.h"
 #include "content/renderer/gpu/gpu_video_decode_accelerator_host.h"
 #include "content/renderer/render_thread.h"
 #include "media/video/video_decode_accelerator.h"
 
 GpuVideoServiceHost::GpuVideoServiceHost()

[scherkus (not reviewing), 2011/06/28 22:02:07]

nit: if the object is created/destroyed on same thread AND has all calls on same
thread, I believe you can inherit from NonThreadSafe<T> and after asserting in
the ctor that yes, this is indeed the render thread, you can use
DCHECK(CalledOnValidThread())

[Ami GONE FROM CHROMIUM, 2011/06/28 22:25:06]

Done.

     : channel_(NULL),
       next_decoder_host_id_(0) {
+  DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());

[scherkus (not reviewing), 2011/06/28 22:02:07]

ditto

[Ami GONE FROM CHROMIUM, 2011/06/28 22:25:06]

Done.

 }
 
 GpuVideoServiceHost::~GpuVideoServiceHost() {
 }
 
-void GpuVideoServiceHost::OnFilterAdded(IPC::Channel* channel) {
-  base::Closure on_initialized;
-  {
-    base::AutoLock auto_lock(lock_);
-    DCHECK(!channel_);
-    channel_ = channel;
-    on_initialized = on_initialized_;
-  }
-  if (!on_initialized.is_null())
-    on_initialized.Run();
-}
-
-void GpuVideoServiceHost::OnFilterRemoved() {
-  // TODO(hclam): Implement.
-}
-
-void GpuVideoServiceHost::OnChannelClosing() {
-  // TODO(hclam): Implement.
+void GpuVideoServiceHost::set_channel(IPC::SyncChannel* channel) {
+  DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());
+  DCHECK(!channel_);
+  channel_ = channel;
+  if (!on_initialized_.is_null())
+    on_initialized_.Run();
 }
 
 bool GpuVideoServiceHost::OnMessageReceived(const IPC::Message& msg) {
+  DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());
+  if (!channel_)
+    return false;
   switch (msg.type()) {
     case AcceleratedVideoDecoderHostMsg_BitstreamBufferProcessed::ID:
     case AcceleratedVideoDecoderHostMsg_ProvidePictureBuffers::ID:
     case AcceleratedVideoDecoderHostMsg_CreateDone::ID:
     case AcceleratedVideoDecoderHostMsg_InitializeDone::ID:
     case AcceleratedVideoDecoderHostMsg_DismissPictureBuffer::ID:
     case AcceleratedVideoDecoderHostMsg_PictureReady::ID:
     case AcceleratedVideoDecoderHostMsg_FlushDone::ID:
     case AcceleratedVideoDecoderHostMsg_AbortDone::ID:
     case AcceleratedVideoDecoderHostMsg_EndOfStream::ID:
     case AcceleratedVideoDecoderHostMsg_ErrorNotification::ID:
       if (router_.RouteMessage(msg))
         return true;
       LOG(ERROR) << "AcceleratedVideoDecoderHostMsg cannot be dispatched.";
     default:
       return false;
   }
 }
 
+void GpuVideoServiceHost::OnChannelError() {
+  DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());
+  channel_ = NULL;
+}
+
 void GpuVideoServiceHost::SetOnInitialized(
     const base::Closure& on_initialized) {
-  IPC::Channel* channel;
-  {
-    base::AutoLock auto_lock(lock_);
-    DCHECK(on_initialized_.is_null());
-    on_initialized_ = on_initialized;
-    channel = channel_;
-  }
-  if (channel)
+  DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());
+  DCHECK(on_initialized_.is_null());
+  on_initialized_ = on_initialized;
+  if (channel_)
     on_initialized.Run();
 }
 
 GpuVideoDecodeAcceleratorHost* GpuVideoServiceHost::CreateVideoAccelerator(
     media::VideoDecodeAccelerator::Client* client,
-    int command_buffer_route_id) {
-  base::AutoLock auto_lock(lock_);
+    int32 command_buffer_route_id,
+    gpu::CommandBufferHelper* cmd_buffer_helper) {
+  DCHECK_EQ(RenderThread::current()->message_loop(), MessageLoop::current());
   DCHECK(channel_);
   return new GpuVideoDecodeAcceleratorHost(
       &router_, channel_, next_decoder_host_id_++,
-      command_buffer_route_id, client);
+      command_buffer_route_id, cmd_buffer_helper, client);
 }