Implement proper synchronization between HW video decode IPC and CommandBuffer.

media/video/video_decode_accelerator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 238 matching lines @@
   //
   // Returns true when command successfully accepted. Otherwise false.
   virtual bool Initialize(const std::vector<uint32>& config) = 0;
 
   // Decodes given bitstream buffer. Once decoder is done with processing
   // |bitstream_buffer| it will call NotifyEndOfBitstreamBuffer() with the
   // bitstream buffer id.
   // Parameters:
   //  |bitstream_buffer| is the input bitstream that is sent for decoding.
   //
   // Returns true when command successfully accepted. Otherwise false.

[scherkus (not reviewing), 2011/06/27 22:54:47]

update docs

[Ami GONE FROM CHROMIUM, 2011/06/28 00:06:35]

Done.

-  virtual bool Decode(const BitstreamBuffer& bitstream_buffer) = 0;
+  virtual void Decode(const BitstreamBuffer& bitstream_buffer) = 0;
 
   // Assigns a set of picture buffers to the video decoder.
   // AssignGLESBuffers assigns texture-backed buffers.
   // AssignSysmemBuffers assigns system memory-backed buffers.
   //
   // Ownership of each picture buffer remains with the client, but the client
   // is not allowed to deallocate the buffer before the DismissPictureBuffer
   // callback has been initiated for a given buffer.
   //
   // Parameters:
   //  |buffers| contains the allocated picture buffers for the output.
   virtual void AssignGLESBuffers(const std::vector<GLESBuffer>& buffers) = 0;
   virtual void AssignSysmemBuffers(
       const std::vector<SysmemBuffer>& buffers) = 0;
 
   // Sends picture buffers to be reused by the decoder. This needs to be called
   // for each buffer that has been processed so that decoder may know onto which
   // picture buffers it can write the output to.
   //
   // Parameters:
   //  |picture_buffer_id| id of the picture buffer that is to be reused.
   virtual void ReusePictureBuffer(int32 picture_buffer_id) = 0;
 
   // Flushes the decoder. Flushing will result in output of the
   // pictures and buffers held inside the decoder and returning of bitstream
   // buffers using the callbacks implemented by the plug-in. Once done with
   // flushing, the decode will call NotifyFlushDone().
   //
   // Returns true when command successfully accepted. Otherwise false.

[scherkus (not reviewing), 2011/06/27 22:54:47]

update docs

[Ami GONE FROM CHROMIUM, 2011/06/28 00:06:35]

Done.

-  virtual bool Flush() = 0;
+  virtual void Flush() = 0;
 
   // Aborts the decoder. Decode will abort the decoding as soon as possible and
   // will not output anything. NotifyAbortDone() is called  as soon as abort has
   // been finished. After abort all buffers can be considered dismissed, even
   // when there has not been callbacks to dismiss them.
   //
   // Returns true when command successfully accepted. Otherwise false.

[scherkus (not reviewing), 2011/06/27 22:54:47]

update docs

[Ami GONE FROM CHROMIUM, 2011/06/28 00:06:35]

Done.

-  virtual bool Abort() = 0;
+  virtual void Abort() = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_