Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: net/base/net_log.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/crl_filter.h ('k') | net/disk_cache/net_log_parameters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log.h
===================================================================
--- net/base/net_log.h (revision 92173)
+++ net/base/net_log.h (working copy)
@@ -13,7 +13,9 @@
#include "base/memory/ref_counted.h"
#include "net/base/net_api.h"
+namespace base {
class Value;
+}
namespace base {
class TimeTicks;
@@ -64,7 +66,7 @@
bool is_valid() const { return id != kInvalidId; }
// The caller takes ownership of the returned Value*.
- Value* ToValue() const;
+ base::Value* ToValue() const;
SourceType type;
uint32 id;
@@ -82,7 +84,7 @@
// Serializes the parameters to a Value tree. This is intended to be a
// lossless conversion, which is used to serialize the parameters to JSON.
// The caller takes ownership of the returned Value*.
- virtual Value* ToValue() const = 0;
+ virtual base::Value* ToValue() const = 0;
private:
DISALLOW_COPY_AND_ASSIGN(EventParameters);
@@ -146,12 +148,12 @@
// Serializes the specified event to a DictionaryValue.
// If |use_strings| is true, uses strings rather than numeric ids.
- static Value* EntryToDictionaryValue(NetLog::EventType type,
- const base::TimeTicks& time,
- const NetLog::Source& source,
- NetLog::EventPhase phase,
- NetLog::EventParameters* params,
- bool use_strings);
+ static base::Value* EntryToDictionaryValue(NetLog::EventType type,
+ const base::TimeTicks& time,
+ const NetLog::Source& source,
+ NetLog::EventPhase phase,
+ NetLog::EventParameters* params,
+ bool use_strings);
private:
DISALLOW_COPY_AND_ASSIGN(NetLog);
@@ -233,7 +235,7 @@
return value_;
}
- virtual Value* ToValue() const;
+ virtual base::Value* ToValue() const;
private:
const char* const name_;
@@ -252,7 +254,7 @@
return value_;
}
- virtual Value* ToValue() const;
+ virtual base::Value* ToValue() const;
private:
const char* name_;
@@ -271,7 +273,7 @@
return value_;
}
- virtual Value* ToValue() const;
+ virtual base::Value* ToValue() const;
private:
const char* name_;
« no previous file with comments | « net/base/crl_filter.h ('k') | net/disk_cache/net_log_parameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698