Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8124)

Unified Diff: chrome/installer/util/google_chrome_distribution.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_chrome_distribution.h
===================================================================
--- chrome/installer/util/google_chrome_distribution.h (revision 92173)
+++ chrome/installer/util/google_chrome_distribution.h (working copy)
@@ -15,9 +15,12 @@
#include "chrome/installer/util/browser_distribution.h"
#include "chrome/installer/util/util_constants.h"
-class DictionaryValue;
class FilePath;
+namespace base {
+class DictionaryValue;
+}
+
class GoogleChromeDistribution : public BrowserDistribution {
public:
// Opens the Google Chrome uninstall survey window.
@@ -115,7 +118,7 @@
const FilePath& file_path, std::wstring* uninstall_metrics);
// Extracts uninstall metrics from the given JSON value.
- virtual bool ExtractUninstallMetrics(const DictionaryValue& root,
+ virtual bool ExtractUninstallMetrics(const base::DictionaryValue& root,
std::wstring* uninstall_metrics);
// Given a DictionaryValue containing a set of uninstall metrics,
@@ -123,7 +126,7 @@
// Returns true if at least one uninstall metric was found in
// uninstall_metrics_dict, false otherwise.
virtual bool BuildUninstallMetricsString(
- DictionaryValue* uninstall_metrics_dict, std::wstring* metrics);
+ base::DictionaryValue* uninstall_metrics_dict, std::wstring* metrics);
// The product ID for Google Update.
std::wstring product_guid_;
« no previous file with comments | « chrome/installer/setup/install.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698