Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3319)

Unified Diff: chrome/browser/prefs/testing_pref_store.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/scoped_user_pref_update.h ('k') | chrome/browser/prefs/value_map_pref_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/testing_pref_store.h
===================================================================
--- chrome/browser/prefs/testing_pref_store.h (revision 92173)
+++ chrome/browser/prefs/testing_pref_store.h (working copy)
@@ -12,8 +12,6 @@
#include "chrome/browser/prefs/pref_value_map.h"
#include "chrome/common/persistent_pref_store.h"
-class DictionaryValue;
-
// |TestingPrefStore| is a preference store implementation that allows tests to
// explicitly manipulate the contents of the store, triggering notifications
// where appropriate.
@@ -24,16 +22,17 @@
// Overriden from PrefStore.
virtual ReadResult GetValue(const std::string& key,
- const Value** result) const;
+ const base::Value** result) const;
virtual void AddObserver(PrefStore::Observer* observer);
virtual void RemoveObserver(PrefStore::Observer* observer);
virtual bool IsInitializationComplete() const;
// PersistentPrefStore overrides:
- virtual ReadResult GetMutableValue(const std::string& key, Value** result);
+ virtual ReadResult GetMutableValue(const std::string& key,
+ base::Value** result);
virtual void ReportValueChanged(const std::string& key);
- virtual void SetValue(const std::string& key, Value* value);
- virtual void SetValueSilently(const std::string& key, Value* value);
+ virtual void SetValue(const std::string& key, base::Value* value);
+ virtual void SetValueSilently(const std::string& key, base::Value* value);
virtual void RemoveValue(const std::string& key);
virtual bool ReadOnly() const;
virtual PersistentPrefStore::PrefReadError ReadPrefs();
« no previous file with comments | « chrome/browser/prefs/scoped_user_pref_update.h ('k') | chrome/browser/prefs/value_map_pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698