Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: chrome/browser/metrics/metrics_log.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/metrics/metrics_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_log.h
===================================================================
--- chrome/browser/metrics/metrics_log.h (revision 92173)
+++ chrome/browser/metrics/metrics_log.h (working copy)
@@ -14,10 +14,13 @@
#include "content/common/page_transition_types.h"
struct AutocompleteLog;
-class DictionaryValue;
class GURL;
class PrefService;
+namespace base {
+class DictionaryValue;
+}
+
namespace webkit {
namespace npapi {
struct WebPluginInfo;
@@ -42,7 +45,7 @@
// dictionary giving the metrics for the profile.
void RecordEnvironment(
const std::vector<webkit::npapi::WebPluginInfo>& plugin_list,
- const DictionaryValue* profile_metrics);
+ const base::DictionaryValue* profile_metrics);
// Records the input text, available choices, and selected entry when the
// user uses the Omnibox to open a URL.
@@ -96,12 +99,13 @@
// Writes all profile metrics. This invokes WriteProfileMetrics for each key
// in all_profiles_metrics that starts with kProfilePrefix.
- void WriteAllProfilesMetrics(const DictionaryValue& all_profiles_metrics);
+ void WriteAllProfilesMetrics(
+ const base::DictionaryValue& all_profiles_metrics);
// Writes metrics for the profile identified by key. This writes all
// key/value pairs in profile_metrics.
void WriteProfileMetrics(const std::string& key,
- const DictionaryValue& profile_metrics);
+ const base::DictionaryValue& profile_metrics);
DISALLOW_COPY_AND_ASSIGN(MetricsLog);
};
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/metrics/metrics_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698