Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 7259015: Fix receiver check in arguments ICs. (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix receiver check in arguments ICs. The receiver needs to be checked in the same way as all other KeyedLoadICs to take non-JSObject and objects that require access checks or has interceptors into account. R=sgjesse@chromium.org BUG=87478 TEST=mjsunit/regress/regress-crbug-87478.js Committed: http://code.google.com/p/v8/source/detail?r=8429

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M src/arm/ic-arm.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +6 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-87478.js View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 6 months ago (2011-06-27 12:49:33 UTC) #1
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-27 13:00:26 UTC) #2
LGTM

http://codereview.chromium.org/7259015/diff/1/test/mjsunit/regress/regress-cr...
File test/mjsunit/regress/regress-crbug-87478.js (right):

http://codereview.chromium.org/7259015/diff/1/test/mjsunit/regress/regress-cr...
test/mjsunit/regress/regress-crbug-87478.js:31: function args(a) { return
arguments; }
Maybe add a comment here that this puts the array[0] IC above into arguments IC
state.

Powered by Google App Engine
This is Rietveld 408576698