Remove scheme restriction for extension context menu items.

Remove scheme restriction for extension context menu items.

BUG=51461, 73631
TEST=Install an extension that adds context menu items - you should now see 
them on pages with schemes like chrome://, file://, chrome-extension://, etc.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92609

[Ben Olmstead, 2011-07-12 00:25:19]

LGTM, modulo updating the documentation.

[asargent_no_longer_on_chrome, 2011-07-12 18:52:14]

Hey Kathy-

Could you take a look at the docs changes I've added here? What I'm doing with
the code changes is making it so that context menu items can appear on any pages
instead of only http/https ones. We'll also want to make sure to include a note
about this in the release notes.

[kathyw, 2011-07-12 21:58:07]

Sure, I'll take a look.

-k-

On Tue, Jul 12, 2011 at 11:52 AM,  <asargent@chromium.org> wrote:
> Hey Kathy-
>
> Could you take a look at the docs changes I've added here? What I'm doing
> with
> the code changes is making it so that context menu items can appear on any
> pages
> instead of only http/https ones. We'll also want to make sure to include a
> note
> about this in the release notes.
>
> http://codereview.chromium.org/7258009/
>

[kathyw, 2011-07-12 22:17:54]

http://codereview.chromium.org/7258009/diff/6001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/contextMenus.html (right):

http://codereview.chromium.org/7258009/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/contextMenus.html:24: experimental, we
limited items to only appear on documents (or frames within documents) whose url
had a scheme of http/https. We've recently removed that restriction, so your
items can appear on any document such as file:// urls, etc. If you'd like to
control which pages your items appear on, see the targetUrlPatterns parameter to
the create and update methods.</p>

We can tighten this up a bit, plus add line breaks on phrases, as in the rest of
the file. How about (fix to match the facts as needed :):

===========
<p>
Context menu items can appear in any document
(or frame within a document),
even those with file:// or chrome:// URLs.
To control which documents your items can appear in,
specify the targetUrlPatterns field
when you call the create() or update() method.
</p>

<p class="note">
<strong>Version note:</strong>
Before Chrome 14, {PENDING: fix version #?}
only http:// and https:// were allowed.
</p>
===========

NOTE:

* Should targetUrlPatterns be documentUrlPatterns? Or maybe both apply? I'm not
clear on how the context and those two fields interact.

* The document uses "apply to" to refer to the context. I didn't use "apply to"
in the description because I didn't think we were referring only to the
page/frame context.

[kathyw, 2011-07-13 15:28:20]

Replying to myself... My suggested note could be clearer.

only http:// and https:// were allowed.
->
your items could appear only in documents with http:// or https:// URLs.

[asargent_no_longer_on_chrome, 2011-07-14 17:33:30]

New version up addressing comments. Kathy - thanks for the edits, and please
take another look.

http://codereview.chromium.org/7258009/diff/6001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/contextMenus.html (right):

http://codereview.chromium.org/7258009/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/contextMenus.html:24: experimental, we
limited items to only appear on documents (or frames within documents) whose url
had a scheme of http/https. We've recently removed that restriction, so your
items can appear on any document such as file:// urls, etc. If you'd like to
control which pages your items appear on, see the targetUrlPatterns parameter to
the create and update methods.</p>
 > * Should targetUrlPatterns be documentUrlPatterns? Or maybe both apply? I'm
not
> clear on how the context and those two fields interact.

Using documentUrlPatterns is correct, because that controls if an item appears
based on the URL of the top-level document (or frame URL, if the click was in a
frame). 

The targetUrlPatterns is for scoping based on the src/href tag when you right
click on elements like <img>, <a>, etc.

[kathyw, 2011-07-14 17:41:08]

LGTM, once you remove the visible PENDING comment

http://codereview.chromium.org/7258009/diff/10001/chrome/common/extensions/do...
File chrome/common/extensions/docs/contextMenus.html (right):

http://codereview.chromium.org/7258009/diff/10001/chrome/common/extensions/do...
chrome/common/extensions/docs/contextMenus.html:361: Before Chrome 14, {PENDING:
fix version #?}
If you aren't sure of the version, could you change this note to a comment?

Before Chrome 14, <!-- PENDING: check version #? -->

[commit-bot: I haz the power, 2011-07-14 22:11:03]

Change committed as 92609