Issue 7258005: Clean up users of a deprecated base::LaunchApp API.

Issue 7258005: Clean up users of a deprecated base::LaunchApp API. (Closed)

Created:
9 years, 5 months ago by Evan Martin

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, Paweł Hajdan Jr., jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean up users of a deprecated base::LaunchApp API. BUG=88990 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92200

Patch Set 2 : copyrights #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -32 lines)			Patch
M	base/process_util.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	base/process_util_unittest.cc	View		3 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_unittest_utils_mac.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/platform_util_linux.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/child_process_launcher.cc	View		2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/7258005/diff/1/content/browser/child_process_launcher.cc File content/browser/child_process_launcher.cc (right): http://codereview.chromium.org/7258005/diff/1/content/browser/child_process_launcher.cc#newcode175 content/browser/child_process_launcher.cc:175: options.environ = &env; Needed? Looks like env is ...

9 years, 5 months ago (2011-07-11 23:12:39 UTC) #2

Evan Martin

On 2011/07/11 23:12:39, Mark Mentovai wrote: > LGTM > > http://codereview.chromium.org/7258005/diff/1/content/browser/child_process_launcher.cc > File content/browser/child_process_launcher.cc (right): ...

9 years, 5 months ago (2011-07-12 17:32:52 UTC) #3

content lgtm

Expand Messages | Collapse Messages