Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: content/browser/debugger/devtools_window.h

Issue 7257002: DevTools: handle docked window close in DevToolsWindow, not DevToolsManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 5 #ifndef CONTENT_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
6 #define CONTENT_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 6 #define CONTENT_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 27 matching lines...) Expand all
38 38
39 // Overridden from DevToolsClientHost. 39 // Overridden from DevToolsClientHost.
40 virtual DevToolsWindow* AsDevToolsWindow(); 40 virtual DevToolsWindow* AsDevToolsWindow();
41 virtual void SendMessageToClient(const IPC::Message& message); 41 virtual void SendMessageToClient(const IPC::Message& message);
42 virtual void InspectedTabClosing(); 42 virtual void InspectedTabClosing();
43 virtual void TabReplaced(TabContentsWrapper* new_tab); 43 virtual void TabReplaced(TabContentsWrapper* new_tab);
44 44
45 void Show(DevToolsToggleAction action); 45 void Show(DevToolsToggleAction action);
46 void Activate(); 46 void Activate();
47 void SetDocked(bool docked); 47 void SetDocked(bool docked);
48 void Close();
48 RenderViewHost* GetRenderViewHost(); 49 RenderViewHost* GetRenderViewHost();
49 50
50 TabContentsWrapper* tab_contents() { return tab_contents_; } 51 TabContentsWrapper* tab_contents() { return tab_contents_; }
51 Browser* browser() { return browser_; } // For tests. 52 Browser* browser() { return browser_; } // For tests.
52 bool is_docked() { return docked_; } 53 bool is_docked() { return docked_; }
53 54
54 private: 55 private:
55 void CreateDevToolsBrowser(); 56 void CreateDevToolsBrowser();
56 bool FindInspectedBrowserAndTabIndex(Browser**, int* tab); 57 bool FindInspectedBrowserAndTabIndex(Browser**, int* tab);
57 BrowserWindow* GetInspectedBrowserWindow(); 58 BrowserWindow* GetInspectedBrowserWindow();
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 TabContentsWrapper* tab_contents_; 95 TabContentsWrapper* tab_contents_;
95 Browser* browser_; 96 Browser* browser_;
96 bool docked_; 97 bool docked_;
97 bool is_loaded_; 98 bool is_loaded_;
98 DevToolsToggleAction action_on_load_; 99 DevToolsToggleAction action_on_load_;
99 NotificationRegistrar registrar_; 100 NotificationRegistrar registrar_;
100 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 101 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
101 }; 102 };
102 103
103 #endif // CONTENT_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 104 #endif // CONTENT_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « content/browser/debugger/devtools_manager.cc ('k') | content/browser/debugger/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698