chrome/browser/resources/new_profile.html - Issue 7256002: Multi-Profiles: New Profile Setup UI

Side by Side Diff: chrome/browser/resources/new_profile.html

Issue 7256002: Multi-Profiles: New Profile Setup UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>
	Evan Stade 2011/07/01 20:33:18 license header license header sail 2011/07/01 23:47:04 Done. Show quoted text On 2011/07/01 20:33:18, Evan Stade wrote: > license header Done.
	2 <html i18n-values="dir:textdirection;

	3 customlogo:customlogo;">

	4 <head>

	5 <meta charset="utf-8">

	6 <title i18n-content="title"></title>

	7 <script src="chrome://newprofile/new_profile.js"></script>

	8 <script src="chrome://resources/js/local_strings.js"></script>

	9 <script src="chrome://resources/js/cr.js"></script>

	10 <script src="chrome://resources/js/util.js"></script>
	Evan Stade 2011/07/01 20:33:18 can you throw in some line returns for readability can you throw in some line returns for readability sail 2011/07/01 23:47:04 Done. Show quoted text On 2011/07/01 20:33:18, Evan Stade wrote: > can you throw in some line returns for readability Done.
	11 <link rel="stylesheet" href="chrome://resources/css/button.css">

	12 <link rel="stylesheet" href="new_profile.css">

	13 </head>

	14 <body i18n-values=".style.fontFamily:fontfamily;">

	15 <div class="overlay">

	16 <div id="new-profile-overlay" class="page">

	17 <h3 i18n-content="summaryTitle"></h3>

	18 <p i18n-content="summaryBody"></p>

	19 <p i18n-content="summaryConclusion"></p>

	20 <div id="outer-input-area">

	21 <div id="inner-input-area">

	22 <div i18n-content="profileNameLabel"> </div>

	23 <div>

	24 <form id="profile-name-form">

	25 <input id="profile-name" type="text">

	26 </form>

	27 </div>

	28 <div i18n-content="profileIconLabel"> </div>
	Evan Stade 2011/07/01 20:33:18 remove blank space here and above remove blank space here and above sail 2011/07/01 23:47:04 Done. Show quoted text On 2011/07/01 20:33:18, Evan Stade wrote: > remove blank space here and above Done.
	29 <div id="avatar-menu"></div>

	30 </div>

	31 </div>

	32 <div class="action-area">

	33 <div class="button-strip">

	34 <input id="cancel-button" type="button"

	35 i18n-values="value:cancelProfile">

	36 <input id="create-button" type="button"

	37 i18n-values="value:createProfile">
	Evan Stade 2011/07/01 20:33:18 i18n-content=foo i18n-content=foo sail 2011/07/01 23:47:04 I don't think this works for <input>. I tried chan Show quoted text On 2011/07/01 20:33:18, Evan Stade wrote: > i18n-content=foo I don't think this works for <input>. I tried changing this to i18n-content="cancelProfile" and it didn't work. Evan Stade 2011/07/01 23:59:36 use <button>. It's more flexible. I don't know of Show quoted text On 2011/07/01 23:47:04, sail wrote: > On 2011/07/01 20:33:18, Evan Stade wrote: > > i18n-content=foo > > I don't think this works for <input>. I tried changing this to > i18n-content="cancelProfile" and it didn't work. use <button>. It's more flexible. I don't know of any reason to ever prefer input type="button". But I am not an expert.
	38 </div>

	39 </div>

	40 </div>

	41 </div>

	42 <div id="footer">

	43 <div id="footer-content">

	44 <img id="logo-img">

	45 </div>

	46 </div>

	47 <script src="chrome://newprofile/strings.js"></script>

	48 <script src="chrome://resources/js/i18n_template.js"></script>

	49 <script src="chrome://resources/js/i18n_process.js"></script>

	50 </body>

	51 </html>

OLD	NEW