Issue 7256001: Fix a few issues with Chrome-in-Views-Desktop:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7256001: Fix a few issues with Chrome-in-Views-Desktop: (Closed)

Created:
9 years, 6 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a few issues with Chrome-in-Views-Desktop: - adds a NativeTabContentsContainerViews, which is just a view that parents the NativeTabContentsViewViews' View. This prevents flicker when switching tabs. - SetPureViews is called earlier during browser_main, so that the desktop widget is created with an input method. This prevents an assert while typing in the omnibox. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90450

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -8 lines)			Patch
M	chrome/browser/browser_main.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/tab_contents/native_tab_contents_container_views.h	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/tab_contents/native_tab_contents_container_views.cc	View		1 chunk	+133 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_views.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages