Chromium Code Reviews| Index: gpu/command_buffer/common/command_buffer.h |
| =================================================================== |
| --- gpu/command_buffer/common/command_buffer.h (revision 91774) |
| +++ gpu/command_buffer/common/command_buffer.h (working copy) |
| @@ -74,17 +74,16 @@ |
| // Returns the current status. |
| virtual State GetState() = 0; |
| + // Returns the last state without synchronizing with the service. |
| + virtual State GetLastState() = 0; |
| + |
| // The writer calls this to update its put offset. This ensures the reader |
| // sees the latest added commands, and will eventually process them. |
|
jbates
2011/07/11 18:39:50
Could use an updated comment here right? Like "on
apatrick_chromium
2011/07/11 21:25:45
Done.
|
| virtual void Flush(int32 put_offset) = 0; |
| // The writer calls this to update its put offset. This function returns the |
| - // reader's most recent get offset. Does not return until after the put offset |
| - // change callback has been invoked. Returns -1 if the put offset is invalid. |
| - // If last_known_get is different from the reader's current get pointer, this |
| - // function will return immediately, otherwise it guarantees that the reader |
| - // has processed some commands before returning (assuming the command buffer |
| - // isn't empty and there is no error). |
| + // reader's most recent get offset. Does not return until all pending commands |
| + // have been executed. |
| virtual State FlushSync(int32 put_offset, int32 last_known_get) = 0; |
| // Sets the current get offset. This can be called from any thread. |