Chromium Code Reviews

Issue 7253041: Use primary/secondary for URLs and patterns everywhere in the content settings extension API. (Closed)

Created:
9 years, 5 months ago by Bernhard Bauer
Modified:
9 years, 5 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., markusheintz_
Visibility:
Public.

Description

Use primary/secondary for URLs and patterns everywhere in the content settings extension API. BUG=71067 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91106

Patch Set 1 #

Patch Set 2 : fix win compile #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Stats (+146 lines, -126 lines)
M chrome/browser/extensions/extension_content_settings_api.cc View 4 chunks +35 lines, -33 lines 0 comments
M chrome/browser/extensions/extension_content_settings_api_constants.h View 1 chunk +4 lines, -4 lines 0 comments
M chrome/browser/extensions/extension_content_settings_api_constants.cc View 1 chunk +4 lines, -4 lines 0 comments
M chrome/browser/extensions/extension_content_settings_store.h View 1 chunk +4 lines, -4 lines 0 comments
M chrome/browser/extensions/extension_content_settings_store.cc View 11 chunks +54 lines, -35 lines 0 comments
M chrome/common/extensions/api/extension_api.json View 8 chunks +16 lines, -14 lines 0 comments
chrome/common/extensions/docs/examples/api/contentSettings.zip View 0 chunks +-1 lines, --1 lines 0 comments
M chrome/common/extensions/docs/examples/api/contentSettings/popup.html View 2 chunks +2 lines, -4 lines 0 comments
M chrome/common/extensions/docs/experimental.contentSettings.html View 14 chunks +16 lines, -16 lines 0 comments
M chrome/common/extensions/docs/samples.json View 1 chunk +1 line, -1 line 0 comments
M chrome/test/data/extensions/api_test/content_settings/standard/test.html View 3 chunks +11 lines, -12 lines 0 comments

Messages

Total messages: 2 (0 generated)
Bernhard Bauer
Please review. Internally in the HostContentSettingsMap we've decided to use just primaryURL/secondaryURL and primaryPattern/secondaryPattern, with ...
9 years, 5 months ago (2011-06-29 15:21:19 UTC) #1
Matt Perry
9 years, 5 months ago (2011-06-29 18:49:39 UTC) #2
LGTM

Powered by Google App Engine