Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 7253041: Use primary/secondary for URLs and patterns everywhere in the content settings extension API. (Closed)

Created:
9 years, 5 months ago by Bernhard Bauer
Modified:
9 years, 5 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., markusheintz_
Visibility:
Public.

Description

Use primary/secondary for URLs and patterns everywhere in the content settings extension API. BUG=71067 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91106

Patch Set 1 #

Patch Set 2 : fix win compile #

Patch Set 3 : fix #

Messages

Total messages: 2 (0 generated)
Bernhard Bauer
Please review. Internally in the HostContentSettingsMap we've decided to use just primaryURL/secondaryURL and primaryPattern/secondaryPattern, with ...
9 years, 5 months ago (2011-06-29 15:21:19 UTC) #1
Matt Perry
9 years, 5 months ago (2011-06-29 18:49:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698