Fixes for OpenSSL

net/socket/ssl_client_socket_openssl.cc

Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 92abf46ffdae1a4e4e91246df3043b627e74abed..3e25e2bb2b3877b8f208d33f5028c05451c58581 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -1094,6 +1094,22 @@ bool SSLClientSocketOpenSSL::UsingTCPFastOpen() const {
   return false;
 }
 
+int64 SSLClientSocketOpenSSL::NumBytesRead() const {
+  if (transport_.get() && transport_->socket())
+    return transport_->socket()->NumBytesRead();
+
+  NOTREACHED();
+  return -1;

[wtc, 2011/07/01 16:41:17]

I think returning 0 here and in GetConnectTimeMicros
is better.  0 is the initial values used by
TCPClientSocketWin and TCPClientSocketLibevent.

I am especially worried about returning a TimeDelta of -1.
That may confuse code.

I know you copied the -1 value from ssl_client_socket_nss.cc.
So this is fine for now.

[bulach, 2011/07/05 10:06:55]

I'll keep this as is now for consistency.
joth pointed out that it'd be cleaner to have:

CHECK(transport_.get() && transport_->socked());
return transport_->socket()->FooBar();

or even better, have some adapter / base class that we could re-use across all
platform rather than duplicate this code..
if you agree with either suggestions, I'm happy to follow up!

On 2011/07/01 16:41:17, wtc wrote:

+}
+
+base::TimeDelta SSLClientSocketOpenSSL::GetConnectTimeMicros() const {
+  if (transport_.get() && transport_->socket())
+    return transport_->socket()->GetConnectTimeMicros();
+
+  NOTREACHED();
+  return base::TimeDelta::FromMicroseconds(-1);
+}
+
 // Socket methods
 
 int SSLClientSocketOpenSSL::Read(IOBuffer* buf,