Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 7253025: Add version aware name resolution (Closed)

Created:
9 years, 6 months ago by noelallen1
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add version aware name resolution Currently the IDL find a parent type by a simple lookup of where a symbol name maps directly to an AST node. This change provides a mechanism for replacing the directy dictionary with a version or version range based search. BUG= http://code.google.com/p/chromium/issues/detail?id=87684 TEST= python idl_namespace.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91427

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -0 lines) Patch
A ppapi/generators/idl_namespace.py View 1 2 1 chunk +345 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noelallen1
9 years, 6 months ago (2011-06-27 23:18:37 UTC) #1
sehr (please use chromium)
LGTM. Some nits. http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespace.py File ppapi/generators/idl_namespace.py (right): http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespace.py#newcode75 ppapi/generators/idl_namespace.py:75: # if the max and min ...
9 years, 5 months ago (2011-07-01 22:58:51 UTC) #2
noelallen1
9 years, 5 months ago (2011-07-02 19:51:32 UTC) #3
Done.  Thanks.

http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespa...
File ppapi/generators/idl_namespace.py (right):

http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespa...
ppapi/generators/idl_namespace.py:75: # if the max and min overlap, than's an
error
On 2011/07/01 22:58:51, sehr wrote:
> This requires that versioned information appear in ascending order also.  You
> should put that in a comment earlier.

Done.

http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespa...
ppapi/generators/idl_namespace.py:220: # Dumps all the information relavent to
an add failure.
On 2011/07/01 22:58:51, sehr wrote:
> relevant

Done.

http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespa...
ppapi/generators/idl_namespace.py:265: # Verify the namespace find the correct
nodes based on range
On 2011/07/01 22:58:51, sehr wrote:
> Can't parse this comment.

Done.

http://codereview.chromium.org/7253025/diff/3001/ppapi/generators/idl_namespa...
ppapi/generators/idl_namespace.py:293: #Verify we succeed with undeprecated adds
On 2011/07/01 22:58:51, sehr wrote:
> s/#V/# V/

Done.

Powered by Google App Engine
This is Rietveld 408576698