net/http/http_cache_transaction.cc - Issue 7253017: Revert 90625

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 7253017: Revert 90625 (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Change NOTREACHED to DCHECK_EQ Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index 9af0c83720d88292039da51d2f74ca25159907d0..7c5b09d5d4d10f7687f3d617e6663d116a12f6e0 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -1516,7 +1516,7 @@ int HttpCache::Transaction::BeginCacheValidation() {

cache_->ConvertWriterToReader(entry_);

mode_ = READ;

- if (entry_ && entry_->disk_entry->GetDataSize(kMetadataIndex))

+ if (entry_->disk_entry->GetDataSize(kMetadataIndex))

next_state_ = STATE_CACHE_READ_METADATA;

} else {

// Make the network request conditional, to see if we may reuse our cached

« no previous file with comments | « no previous file | remoting/base/decompressor_zlib.cc » ('j') | no next file with comments »