Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: gcl.py

Issue 7253015: Remove manual --tbr support and convert it into automatic TBR= detection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: removed tests/tbr.sh Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | git_cl.py » ('j') | presubmit_canned_checks.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """\ 6 """\
7 Wrapper script around Rietveld's upload.py that simplifies working with groups 7 Wrapper script around Rietveld's upload.py that simplifies working with groups
8 of files. 8 of files.
9 """ 9 """
10 10
(...skipping 1216 matching lines...) Expand 10 before | Expand all | Expand 10 after
1227 change_info.patchset, 1227 change_info.patchset,
1228 None) 1228 None)
1229 output = presubmit_support.DoPresubmitChecks( 1229 output = presubmit_support.DoPresubmitChecks(
1230 change=change, 1230 change=change,
1231 committing=committing, 1231 committing=committing,
1232 verbose=False, 1232 verbose=False,
1233 output_stream=sys.stdout, 1233 output_stream=sys.stdout,
1234 input_stream=sys.stdin, 1234 input_stream=sys.stdin,
1235 default_presubmit=root_presubmit, 1235 default_presubmit=root_presubmit,
1236 may_prompt=may_prompt, 1236 may_prompt=may_prompt,
1237 tbr=False,
1238 rietveld_obj=change_info.RpcServer()) 1237 rietveld_obj=change_info.RpcServer())
1239 if not output.should_continue() and may_prompt: 1238 if not output.should_continue() and may_prompt:
1240 # TODO(dpranke): move into DoPresubmitChecks(), unify cmd line args. 1239 # TODO(dpranke): move into DoPresubmitChecks(), unify cmd line args.
1241 print "\nPresubmit errors, can't continue (use --no_presubmit to bypass)" 1240 print "\nPresubmit errors, can't continue (use --no_presubmit to bypass)"
1242 1241
1243 return output 1242 return output
1244 1243
1245 1244
1246 @no_args 1245 @no_args
1247 def CMDchanges(): 1246 def CMDchanges():
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1461 raise 1460 raise
1462 print >> sys.stderr, ( 1461 print >> sys.stderr, (
1463 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith ' 1462 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
1464 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)) 1463 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
1465 return 1 1464 return 1
1466 1465
1467 1466
1468 if __name__ == "__main__": 1467 if __name__ == "__main__":
1469 fix_encoding.fix_encoding() 1468 fix_encoding.fix_encoding()
1470 sys.exit(main(sys.argv[1:])) 1469 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « no previous file | git_cl.py » ('j') | presubmit_canned_checks.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698