Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2499)

Unified Diff: content/renderer/media/audio_renderer_impl_unittest.cc

Issue 7253003: Change audio renderer to communicate with host using low latency codepath. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_renderer_impl.cc ('k') | media/audio/audio_output_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_renderer_impl_unittest.cc
===================================================================
--- content/renderer/media/audio_renderer_impl_unittest.cc (revision 91508)
+++ content/renderer/media/audio_renderer_impl_unittest.cc (working copy)
@@ -13,11 +13,28 @@
using ::testing::Return;
+// Class we would be tesing. The only difference between it and "real" one
+// is that test class does not open sockets and launch audio thread.
+class TestAudioRendererImpl : public AudioRendererImpl {
+ public:
+ explicit TestAudioRendererImpl(AudioMessageFilter* filter)
+ : AudioRendererImpl(filter) {
+ }
+ private:
+ virtual void CreateSocket(base::SyncSocket::Handle socket_handle) {}
+ virtual void CreateAudioThread() {}
+};
+
class AudioRendererImplTest : public ::testing::Test {
public:
static const int kRouteId = 0;
static const int kSize = 1024;
+ static void SetUpTestCase() {
+ // Set low latency mode, as it soon would be on by default.
+ AudioRendererImpl::set_latency_type(AudioRendererImpl::kLowLatency);
+ }
+
AudioRendererImplTest() {
message_loop_.reset(new MessageLoop(MessageLoop::TYPE_IO));
@@ -38,7 +55,7 @@
44100)));
// Create and initialize audio renderer.
- renderer_ = new AudioRendererImpl(filter_);
+ renderer_ = new TestAudioRendererImpl(filter_);
renderer_->set_host(&host_);
renderer_->Initialize(decoder_, media::NewExpectedCallback());
@@ -50,13 +67,20 @@
base::SharedMemoryHandle duplicated_handle;
EXPECT_TRUE(shared_mem_.ShareToProcess(base::GetCurrentProcessHandle(),
&duplicated_handle));
-
- renderer_->OnCreated(duplicated_handle, kSize);
+ CallOnCreated(duplicated_handle);
}
virtual ~AudioRendererImplTest() {
}
+ void CallOnCreated(base::SharedMemoryHandle handle) {
+ if (renderer_->latency_type() == AudioRendererImpl::kHighLatency) {
+ renderer_->OnCreated(handle, kSize);
+ } else {
+ renderer_->OnLowLatencyCreated(handle, 0, kSize);
+ }
+ }
+
protected:
// Fixtures.
scoped_ptr<MessageLoop> message_loop_;
@@ -96,11 +120,13 @@
// Run AudioMessageFilter::Delegate methods, which can be executed after being
// stopped. AudioRendererImpl shouldn't create any messages.
- renderer_->OnRequestPacket(AudioBuffersState(kSize, 0));
+ if (renderer_->latency_type() == AudioRendererImpl::kHighLatency) {
+ renderer_->OnRequestPacket(AudioBuffersState(kSize, 0));
+ }
renderer_->OnStateChanged(kAudioStreamError);
renderer_->OnStateChanged(kAudioStreamPlaying);
renderer_->OnStateChanged(kAudioStreamPaused);
- renderer_->OnCreated(shared_mem_.handle(), kSize);
+ CallOnCreated(shared_mem_.handle());
renderer_->OnVolume(0.5);
// It's possible that the upstream decoder replies right after being stopped.
« no previous file with comments | « content/renderer/media/audio_renderer_impl.cc ('k') | media/audio/audio_output_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698