GTK: Remove the global bookmarks menu. It can't be implemented efficiently.

GTK: Remove the global bookmarks menu by default. Currently, it can't be implemented efficiently.

We suspect that Ubuntu's appmenu code can not efficiently handle hundreds or
thousands of menu items, especially when we both initially push the default
16x16 favicon, and then push the asynchronously loaded favicon. We don't
believe this is a problem in chrome's code since this issue only manifests
itself on Natty, and stack traces in bug #86715 are stuck waiting on dbus in
ubuntu's dbusmenu-glib code.

Puts the bookmark menu behind a flag so other people downstream can debug what's going on. Also reduces the number of iconed menu items to 16, ensuring that at most 16k of favicon data is sent over dbus. (The menus felt overly cluttered previously, anyway.)

BUG=86715, 85466
TEST=Have hundreds (thousands?) of bookmarks in your profile. chrome startup shouldn't take minutes on Ubuntu Natty on a desktop that uses appmenu-gtk.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90417

[Evan Martin, 2011-06-24 17:52:08]

I think we don't wanna exactly delete this -- in theory it can be fixed by
upstream.  Maybe just put it behind a flag so upstream can test and fix it?

[Elliot Glaysher, 2011-06-24 18:28:03]

ptal

[Evan Martin, 2011-06-24 18:33:07]

LGTM

[commit-bot: I haz the power, 2011-06-24 20:09:05]

Change committed as 90417