Remove files without an extension from the presubmit checks.

presubmit_support.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.6.1'
 
@@ skipping 168 matching lines @@
 
 class InputApi(object):
   """An instance of this object is passed to presubmit scripts so they can
   know stuff about the change they're looking at.
   """
   # Method could be a function
   # pylint: disable=R0201
 
   # File extensions that are considered source files from a style guide
   # perspective. Don't modify this list from a presubmit script!
+  #
+  # Files without an extension aren't included in the list. If you want to
+  # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
+  # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.

[Dirk Pranke, 2011/06/24 18:58:34]

Aside ... I wonder if we should change this to just be a list of strings to
match on extensions, and transform them into regexps internally. It might be
less flexible, but it would also be clearer and less error-prone.

[M-A Ruel, 2011/06/24 19:11:36]

Make sense but some of them wouldn't work so it would be a mix of raw regex and
list of extensions. I'll do that when I'm bored. :)

   DEFAULT_WHITE_LIST = (
       # C++ and friends
       r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
       r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
       # Scripts
       r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
-      # No extension at all, note that ALL CAPS files are black listed in
-      # DEFAULT_BLACK_LIST below.
-      r"(^|.*?[\\\/])[^.]+$",
       # Other
       r".+\.java$", r".+\.mk$", r".+\.am$",
   )
 
   # Path regexp that should be excluded from being considered containing source
   # files. Don't modify this list from a presubmit script!
   DEFAULT_BLACK_LIST = (
       r".*\bexperimental[\\\/].*",
       r".*\bthird_party[\\\/].*",
       # Output directories (just in case)
@@ skipping 1039 matching lines @@
   except PresubmitFailure, e:
     print >> sys.stderr, e
     print >> sys.stderr, 'Maybe your depot_tools is out of date?'
     print >> sys.stderr, 'If all fails, contact maruel@'
     return 2
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(Main(None))