Added guts to pull call signatures when assertions & expectations fail.

chrome/browser/ui/webui/javascript2webui.js

Index: chrome/browser/ui/webui/javascript2webui.js
diff --git a/chrome/browser/ui/webui/javascript2webui.js b/chrome/browser/ui/webui/javascript2webui.js
index a61a4adc746ba0d3848434aa530f4e972db64175..6ae69b83b54d05a64ae187c965730c3b31ea78ed 100644
--- a/chrome/browser/ui/webui/javascript2webui.js
+++ b/chrome/browser/ui/webui/javascript2webui.js
@@ -19,6 +19,9 @@ if (!('test_fixture' in this)) {
   print(js_file + ' did not define test_fixture.');
   quit(-1);
 }
+if (!('test_assert' in this)) {
+  this['test_assert'] = 'ASSERT_TRUE';

[David Tseng, 2011/07/08 22:37:18]

Why don't we just make this a boolean and resolve to the right macro here?  The
test js file would just say true/false for tests passing/failing.

Also, this is scoped to the entire file.  You can't selectively say that 
test1 
 ASSERT_TRUE(RunJavaScriptTest(foo)
test2
ASSERT_FALSE(RunJavaScriptTest(bar)
within the same js file.

+}
 print('// GENERATED FILE');
 print('// ' + arguments.join(' '));
 print('// PLEASE DO NOT HAND EDIT!');
@@ -27,7 +30,7 @@ for (var func in this) {
   if (!prevfuncs[func] && this[func] instanceof Function) {
     print('IN_PROC_BROWSER_TEST_F(' + test_fixture + ', ' + func + ') {');
     print('  AddLibrary(FilePath(FILE_PATH_LITERAL("' + js_file_base + '")));');

[David Tseng, 2011/07/08 22:37:18]

Doesn't this belong in SetUpTestFixture?

[Sheridan Rawlins, 2011/07/14 23:32:31]

Yeah, this was overhauled in another patch.

On 2011/07/08 22:37:18, David Tseng wrote:

-    print('  ASSERT_TRUE(RunJavascriptTest("' + func + '"));');
+    print('  ' + test_assert + '(RunJavascriptTest("' + func + '"));');
     print('}');
     print();
   }