Added guts to pull call signatures when assertions & expectations fail.

chrome/browser/ui/webui/javascript2webui.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 if (arguments.length < 3) {
   print('usage: ' +
         arguments[0] + ' path-to-testfile.js testfile.js [output.cc]');

[David Tseng, 2011/07/08 22:37:18]

Nit:  is this really the usage?  How do I run this using v8 shell?

   quit();
 }
 var js_file = arguments[1];

[David Tseng, 2011/07/08 22:37:18]

Contradicts usage message above
path-to-testfile.js testfile.js 

[Sheridan Rawlins, 2011/07/14 23:32:31]

Why? argv[0] is always the program name.

On 2011/07/08 22:37:18, David Tseng wrote:

[David Tseng, 2011/07/18 16:41:37]

It's not clear from the usage message what the params are.

i.e.
path-to-testfile.js vs
testfile.js

what's the difference?  Is one meant to be a path?

Also, v8 shell's binary is always called "shell" isn't it?  We should probably
mention that this js file is meant to be executed with the V8 shell and provide
a link since this is our only documentation.
On 2011/07/14 23:32:31, Sheridan Rawlins wrote:

[Sheridan Rawlins, 2011/07/18 17:44:03]

As we discussed, I rolled this file back.  I filed http://crbug.com/89613 to
clean-up documentation/comment-generation.

-SCR

On 2011/07/18 16:41:37, David Tseng wrote:

 var js_file_base = arguments[2];

[David Tseng, 2011/07/08 22:37:18]

This contradicts your usage message above:
path-to-testfile.js testfile.js .

Perhaps name it library?

[Sheridan Rawlins, 2011/07/14 23:32:31]

Can you please describe the conflict?

On 2011/07/08 22:37:18, David Tseng wrote:

 var outputfile = arguments[3];
 var prevfuncs = {};
 for (var func in this) {
   if (this[func] instanceof Function)
     prevfuncs[func] = func;
 }
 var js = load(js_file);
 if (!('test_fixture' in this)) {

[David Tseng, 2011/07/08 22:37:18]

is this a string?  Should we check to make sure?

[Sheridan Rawlins, 2011/07/14 23:32:31]

It should be a constructor. I suppose we could check its signature, but I'm
going to roll back changes to this file.

On 2011/07/08 22:37:18, David Tseng wrote:

   print(js_file + ' did not define test_fixture.');
   quit(-1);
 }
+if (!('test_assert' in this)) {
+  this['test_assert'] = 'ASSERT_TRUE';

[David Tseng, 2011/07/08 22:37:18]

Why don't we just make this a boolean and resolve to the right macro here?  The
test js file would just say true/false for tests passing/failing.

Also, this is scoped to the entire file.  You can't selectively say that 
test1 
 ASSERT_TRUE(RunJavaScriptTest(foo)
test2
ASSERT_FALSE(RunJavaScriptTest(bar)
within the same js file.

+}
 print('// GENERATED FILE');
 print('// ' + arguments.join(' '));
 print('// PLEASE DO NOT HAND EDIT!');
 print();
 for (var func in this) {
   if (!prevfuncs[func] && this[func] instanceof Function) {
     print('IN_PROC_BROWSER_TEST_F(' + test_fixture + ', ' + func + ') {');
     print('  AddLibrary(FilePath(FILE_PATH_LITERAL("' + js_file_base + '")));');

[David Tseng, 2011/07/08 22:37:18]

Doesn't this belong in SetUpTestFixture?

[Sheridan Rawlins, 2011/07/14 23:32:31]

Yeah, this was overhauled in another patch.

On 2011/07/08 22:37:18, David Tseng wrote:

-    print('  ASSERT_TRUE(RunJavascriptTest("' + func + '"));');
+    print('  ' + test_assert + '(RunJavascriptTest("' + func + '"));');
     print('}');
     print();
   }
 }