Issue 7250004: Expose list of all running shared workers at chrome://workers

Issue 7250004: Expose list of all running shared workers at chrome://workers (Closed)

Created:
9 years, 5 months ago by yurys

Modified:
9 years, 5 months ago

Reviewers:
Dmitry Titov, pfeldman

CC:
chromium-reviews, arv (Not doing code reviews), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Expose list of all running shared workers at chrome://workers This page will be used for opening DevTools window for shared workers. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91470

Patch Set 1 #

Patch Set 2 : Removed blank line #

Total comments: 2

Patch Set 3 : Comments addressed #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -0 lines)			Patch
A	chrome/browser/resources/workers/index.html	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/workers_resources.grd	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_factory.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/workers_ui.h	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/workers_ui.cc	View		1 chunk	+107 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/grit/resource_ids	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM! http://codereview.chromium.org/7250004/diff/2001/chrome/browser/resources/workers/index.html File chrome/browser/resources/workers/index.html (right): http://codereview.chromium.org/7250004/diff/2001/chrome/browser/resources/workers/index.html#newcode37 chrome/browser/resources/workers/index.html:37: for (var j = 0; j < worker_properties.length; ...

9 years, 5 months ago (2011-07-04 10:17:57 UTC) #2

yurys

http://codereview.chromium.org/7250004/diff/2001/chrome/browser/resources/workers/index.html File chrome/browser/resources/workers/index.html (right): http://codereview.chromium.org/7250004/diff/2001/chrome/browser/resources/workers/index.html#newcode37 chrome/browser/resources/workers/index.html:37: for (var j = 0; j < worker_properties.length; j++) ...

9 years, 5 months ago (2011-07-04 10:23:22 UTC) #3

Dmitry Titov

9 years, 5 months ago (2011-07-06 17:49:04 UTC) #4

Awesome. But it needs a test - there is a significant chunk of new code and a
visible feature that is not tested. Could you add one?

Expand Messages | Collapse Messages