Refactor the glib message-pump, and use it as the base for a gtk message pump and an X message pump.

media/media.gyp

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'player_x11_renderer%': 'x11',
   },
   'targets': [
@@ skipping 660 matching lines @@
     ['os_posix == 1 and OS != "mac"', {
       'targets': [
         {
           'target_name': 'omx_test',
           'type': 'executable',
           'dependencies': [
             'media',
             '../third_party/ffmpeg/ffmpeg.gyp:ffmpeg',
             '../third_party/openmax/openmax.gyp:il',
           ],
+          'conditions': [
+            ['touchui == 1', {
+              'dependencies': [
+                '../build/linux/system.gyp:gtk',

[Ami GONE FROM CHROMIUM, 2011/06/24 15:55:02]

This looks strange to me, since none of the sources listed below for this target
actually explicitly use GTK/GLIB (or MessagePump, for that matter).
From a short glance through the trybots I'm guessing you made this change to
address:
http://build.chromium.org/p/tryserver.chromium/builders/linux_touch/builds/18...
wouldn't a more principled fix be to have this stanza in base/base.gypi:base,
where message_pump_glib_x.cc and friends are pulled into the build in the first
place?

(i.e. doing it the way you propose requires adding this stanza to every binary
that depends on base, no?  I'm not seeing what's special about omx_test that it
should be different in this regard)

[sadrul, 2011/06/24 17:14:01]

omx_test.cc uses the message_loop. Would it be a good idea to have this always
depend on 'base' instead? I have added this, and this also fixes the problem.
I agree. This would definitely be the better way of doing things. (I honestly
didn't look into it too much since I noticed that omx_unittests does pull in
system.gyp:gtk explicitly, and this change will be removed anyway once we have
NativeWidgetX (soonish, http://codereview.chromium.org/7236030/))

+              ],
+            }],
+          ],
           'sources': [
             'tools/omx_test/color_space_util.cc',
             'tools/omx_test/color_space_util.h',
             'tools/omx_test/file_reader_util.cc',
             'tools/omx_test/file_reader_util.h',
             'tools/omx_test/file_sink.cc',
             'tools/omx_test/file_sink.h',
             'tools/omx_test/omx_test.cc',
           ],
         },
@@ skipping 98 matching lines @@
       ],
     }],
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: