chrome/browser/ui/webui/net_internals_ui.cc - Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals_ui.cc

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: correct nits Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/net_internals_ui.cc

diff --git a/chrome/browser/ui/webui/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals_ui.cc

index 9579dbe895a9956f13af2446d4b926a38befc435..0811419683befd510ec85aaa5efb8fa42c4e09cf 100644

--- a/chrome/browser/ui/webui/net_internals_ui.cc

+++ b/chrome/browser/ui/webui/net_internals_ui.cc

@@ -28,7 +28,6 @@

#include "chrome/browser/net/connection_tester.h"

#include "chrome/browser/net/passive_log_collector.h"

#include "chrome/browser/net/url_fixer_upper.h"

-#include "chrome/browser/platform_util.h"

#include "chrome/browser/prefs/pref_member.h"

#include "chrome/browser/prerender/prerender_manager.h"

#include "chrome/browser/profiles/profile.h"

@@ -896,7 +895,7 @@ void NetInternalsMessageHandler::IOThreadImpl::OnRendererReady(

dict->SetString("version", version_info.Version());

dict->SetString("cl", version_info.LastChange());

dict->SetString("version_mod",

- platform_util::GetVersionStringModifier());

+ chrome::VersionInfo::GetVersionStringModifier());

dict->SetString("official",

l10n_util::GetStringUTF16(

version_info.IsOfficialBuild() ?

« no previous file with comments | « chrome/browser/ui/webui/gpu_internals_ui.cc ('k') | chrome/browser/ui/webui/options/about_page_handler.cc » ('j') | no next file with comments »