chrome/browser/ui/cocoa/about_window_controller.mm - Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/about_window_controller.mm

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: correct nits Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/about_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/about_window_controller.mm b/chrome/browser/ui/cocoa/about_window_controller.mm

index 0e73b577796336c14bfd77c75e9506c3f1048ac5..e0efd1924e5d0166ef1065d940f84fdcd74aaa89 100644

--- a/chrome/browser/ui/cocoa/about_window_controller.mm

+++ b/chrome/browser/ui/cocoa/about_window_controller.mm

@@ -11,11 +11,11 @@

#include "base/sys_string_conversions.h"

#include "chrome/browser/google/google_util.h"

#import "chrome/browser/mac/keystone_glue.h"

-#include "chrome/browser/platform_util.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window.h"

#import "chrome/browser/ui/cocoa/background_tile_view.h"

#include "chrome/browser/ui/cocoa/restart_browser.h"

+#include "chrome/common/chrome_version_info.h"

#include "chrome/common/url_constants.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

@@ -136,7 +136,7 @@ static BOOL recentShownUserActionFailedStatus = NO;

NSString* versionModifier = @"";

NSString* svnRevision = @"";

- std::string modifier = platform_util::GetVersionStringModifier();

+ std::string modifier = chrome::VersionInfo::GetVersionStringModifier();

if (!modifier.empty())

versionModifier = [NSString stringWithFormat:@" %@",

base::SysUTF8ToNSString(modifier)];

« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/ui/cocoa/first_run_dialog.mm » ('j') | no next file with comments »