chrome/browser/ui/webui/options/about_page_handler.cc - Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/about_page_handler.cc

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info.cc Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/about_page_handler.cc

diff --git a/chrome/browser/ui/webui/options/about_page_handler.cc b/chrome/browser/ui/webui/options/about_page_handler.cc

index 988ed81e714e99cb77b96d4318e957a22379c3cf..e50e00843083fb7eaf10aa0aa889bee1c451f187 100644

--- a/chrome/browser/ui/webui/options/about_page_handler.cc

+++ b/chrome/browser/ui/webui/options/about_page_handler.cc

@@ -16,7 +16,6 @@

#include "base/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/browser/google/google_util.h"

-#include "chrome/browser/platform_util.h"

#include "chrome/common/chrome_version_info.h"

#include "chrome/common/url_constants.h"

#include "googleurl/src/gurl.h"

@@ -142,7 +141,8 @@ void AboutPageHandler::GetLocalizedValues(DictionaryValue* localized_strings) {

DCHECK(version_info.is_valid());

std::string browser_version = version_info.Version();

- std::string version_modifier = platform_util::GetVersionStringModifier();

+ std::string version_modifier =

+ chrome::VersionInfo::GetVersionStringModifier();

if (!version_modifier.empty())

browser_version += " " + version_modifier;

« no previous file with comments | « chrome/browser/ui/webui/net_internals_ui.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | chrome/chrome_common.gypi » ('J')