Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: chrome/browser/browser_about_handler.cc

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: correct nits Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/browser_main.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_about_handler.h" 5 #include "chrome/browser/browser_about_handler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 14 matching lines...) Expand all
25 #include "base/tracked_objects.h" 25 #include "base/tracked_objects.h"
26 #include "base/utf_string_conversions.h" 26 #include "base/utf_string_conversions.h"
27 #include "base/values.h" 27 #include "base/values.h"
28 #include "chrome/browser/about_flags.h" 28 #include "chrome/browser/about_flags.h"
29 #include "chrome/browser/browser_process.h" 29 #include "chrome/browser/browser_process.h"
30 #include "chrome/browser/defaults.h" 30 #include "chrome/browser/defaults.h"
31 #include "chrome/browser/memory_details.h" 31 #include "chrome/browser/memory_details.h"
32 #include "chrome/browser/metrics/histogram_synchronizer.h" 32 #include "chrome/browser/metrics/histogram_synchronizer.h"
33 #include "chrome/browser/net/predictor_api.h" 33 #include "chrome/browser/net/predictor_api.h"
34 #include "chrome/browser/net/url_fixer_upper.h" 34 #include "chrome/browser/net/url_fixer_upper.h"
35 #include "chrome/browser/platform_util.h"
36 #include "chrome/browser/profiles/profile.h" 35 #include "chrome/browser/profiles/profile.h"
37 #include "chrome/browser/profiles/profile_manager.h" 36 #include "chrome/browser/profiles/profile_manager.h"
38 #include "chrome/browser/ui/browser_dialogs.h" 37 #include "chrome/browser/ui/browser_dialogs.h"
39 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 38 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
40 #include "chrome/common/about_handler.h" 39 #include "chrome/common/about_handler.h"
41 #include "chrome/common/chrome_paths.h" 40 #include "chrome/common/chrome_paths.h"
42 #include "chrome/common/chrome_version_info.h" 41 #include "chrome/common/chrome_version_info.h"
43 #include "chrome/common/jstemplate_builder.h" 42 #include "chrome/common/jstemplate_builder.h"
44 #include "chrome/common/net/gaia/google_service_auth_error.h" 43 #include "chrome/common/net/gaia/google_service_auth_error.h"
45 #include "chrome/common/render_messages.h" 44 #include "chrome/common/render_messages.h"
(...skipping 935 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 std::string js_engine = "JavaScriptCore"; 980 std::string js_engine = "JavaScriptCore";
982 #endif 981 #endif
983 982
984 localized_strings->SetString("name", 983 localized_strings->SetString("name",
985 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)); 984 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
986 localized_strings->SetString("version", version_info.Version()); 985 localized_strings->SetString("version", version_info.Version());
987 // Bug 79458: Need to evaluate the use of getting the version string on 986 // Bug 79458: Need to evaluate the use of getting the version string on
988 // this thread. 987 // this thread.
989 base::ThreadRestrictions::ScopedAllowIO allow_io; 988 base::ThreadRestrictions::ScopedAllowIO allow_io;
990 localized_strings->SetString("version_modifier", 989 localized_strings->SetString("version_modifier",
991 platform_util::GetVersionStringModifier()); 990 chrome::VersionInfo::GetVersionStringModifier());
992 localized_strings->SetString("os_name", 991 localized_strings->SetString("os_name",
993 l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_OS)); 992 l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_OS));
994 localized_strings->SetString("os_type", version_info.OSType()); 993 localized_strings->SetString("os_type", version_info.OSType());
995 localized_strings->SetString("webkit_version", webkit_version); 994 localized_strings->SetString("webkit_version", webkit_version);
996 localized_strings->SetString("js_engine", js_engine); 995 localized_strings->SetString("js_engine", js_engine);
997 localized_strings->SetString("js_version", js_version); 996 localized_strings->SetString("js_version", js_version);
998 997
999 // Obtain the version of the first enabled Flash plugin. 998 // Obtain the version of the first enabled Flash plugin.
1000 std::vector<webkit::npapi::WebPluginInfo> info_array; 999 std::vector<webkit::npapi::WebPluginInfo> info_array;
1001 webkit::npapi::PluginList::Singleton()->GetPluginInfoArray( 1000 webkit::npapi::PluginList::Singleton()->GetPluginInfoArray(
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 return false; 1395 return false;
1397 } 1396 }
1398 1397
1399 std::vector<std::string> ChromePaths() { 1398 std::vector<std::string> ChromePaths() {
1400 std::vector<std::string> paths; 1399 std::vector<std::string> paths;
1401 paths.reserve(arraysize(kChromePaths)); 1400 paths.reserve(arraysize(kChromePaths));
1402 for (size_t i = 0; i < arraysize(kChromePaths); i++) 1401 for (size_t i = 0; i < arraysize(kChromePaths); i++)
1403 paths.push_back(kChromePaths[i]); 1402 paths.push_back(kChromePaths[i]);
1404 return paths; 1403 return paths;
1405 } 1404 }
OLDNEW
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698