Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: content/browser/debugger/devtools_window.cc

Issue 7248076: DevTools: add initial support for shared workers debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactored worker_devtools_agent.cc Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/devtools_window.cc
diff --git a/content/browser/debugger/devtools_window.cc b/content/browser/debugger/devtools_window.cc
index 1c4e7e641acca8de09876cf8c5269704a6c6ca91..818f3b78fae41124eb2e9992f4e03582e15cfbec 100644
--- a/content/browser/debugger/devtools_window.cc
+++ b/content/browser/debugger/devtools_window.cc
@@ -75,6 +75,12 @@ DevToolsWindow* DevToolsWindow::FindDevToolsWindow(
}
// static
+DevToolsWindow* DevToolsWindow::CreateDevToolsWindowForWorker(
+ Profile* profile) {
+ return new DevToolsWindow(profile, NULL, false);
+}
+
+// static
DevToolsWindow* DevToolsWindow::OpenDevToolsWindow(
RenderViewHost* inspected_rvh) {
return ToggleDevToolsWindow(inspected_rvh, true,
@@ -131,10 +137,12 @@ DevToolsWindow::DevToolsWindow(Profile* profile,
this,
chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
Source<ThemeService>(ThemeServiceFactory::GetForProfile(profile_)));
- TabContents* tab = inspected_rvh->delegate()->GetAsTabContents();
- if (tab)
- inspected_tab_ = TabContentsWrapper::GetCurrentWrapperForContents(tab);
-
+ // There is no inspected_rvh in case of shared workers.
+ if (inspected_rvh) {
+ TabContents* tab = inspected_rvh->delegate()->GetAsTabContents();
+ if (tab)
+ inspected_tab_ = TabContentsWrapper::GetCurrentWrapperForContents(tab);
+ }
instances_.push_back(this);
}

Powered by Google App Engine
This is Rietveld 408576698