Issue 7248068: Rename range.mm to range_mac.mm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7248068: Rename range.mm to range_mac.mm. (Closed)

Created:
9 years, 5 months ago by Nico

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, Robert Sesek, commit-bot: I haz the power, Ryan Sleevi

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rename range.mm to range_mac.mm. For consistency, move the windows-specific code from range.cc into range_win.cc. Do the same for unit tests. In addition to this being nicer in general, the make build also gets confused if two files have the same path and basename, but different extensions (range.cc, range.mm), which is fixed by this CL. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91480

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -172 lines)			Patch
M	ui/base/range/range.cc	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	ui/base/range/range.mm	View	1 chunk	+0 lines, -36 lines	0 comments	Download
A +	ui/base/range/range_mac.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/base/range/range_mac_unittest.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/base/range/range_unittest.cc	View	1 chunk	+0 lines, -59 lines	0 comments	Download
D	ui/base/range/range_unittest.mm	View	1 chunk	+0 lines, -43 lines	0 comments	Download
A	ui/base/range/range_win.cc	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	ui/base/range/range_win_unittest.cc	View	1 chunk	+63 lines, -0 lines	0 comments	Download
M	ui/ui_base.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/ui_unittests.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM. How un-patriotic of you, though.

Expand Messages | Collapse Messages