Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 7248063: Simplify UnaryOpStub a little bit. (Closed)

Created:
9 years, 5 months ago by Sven Panne
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Simplify UnaryOpStub a little bit. Only a single constructor is really needed. Make UnaryOp_Patch's arguments simpler, avoiding encoding/decoding things in a cryptic way. Committed: http://code.google.com/p/v8/source/detail?r=8503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -86 lines) Patch
M src/arm/code-stubs-arm.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +4 lines, -10 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/ic.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 5 months ago (2011-06-30 14:59:51 UTC) #1
Mads Ager (chromium)
9 years, 5 months ago (2011-07-01 07:05:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698