Heap profiler: annotate fixed arrays by their purpose.

Heap profiler: annotate fixed arrays by their purpose.

This helps understanding what is a particular array for by
just looking at its name.

R=vitalyr@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=8494

[Vitaly Repeshko, 2011-06-30 12:41:44]

http://codereview.chromium.org/7248058/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/7248058/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1877: if (js_fun->unchecked_context()->IsContext()) {
How about instead of having TagFoo functions just have one TagObject checking
its parameter is a heap object and not an oddball or a singleton?

http://codereview.chromium.org/7248058/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1909: TagFixedArray(context->map_cache(), "(context map
cache)");
This made me realize our map cache is just leaking!

[mnaganov (inactive), 2011-06-30 13:37:05]

http://codereview.chromium.org/7248058/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/7248058/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1877: if (js_fun->unchecked_context()->IsContext()) {
On 2011/06/30 12:41:44, Vitaly Repeshko wrote:
> How about instead of having TagFoo functions just have one TagObject checking
> its parameter is a heap object and not an oddball or a singleton?

Done.

[Vitaly Repeshko, 2011-06-30 13:45:27]

LGTM

http://codereview.chromium.org/7248058/diff/4001/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/7248058/diff/4001/src/profile-generator.cc#new...
src/profile-generator.cc:1903: TagObject(context->jsfunction_result_caches(),
"(context func caches)");
nit: Maybe we should avoid abbreviations? The names are already quite confusing.

http://codereview.chromium.org/7248058/diff/4001/src/profile-generator.cc#new...
src/profile-generator.cc:1916: objects_tags_.SetTag(map->instance_descriptors(),
"(map descriptors)");
Use TagObject here?

[mnaganov (inactive), 2011-06-30 14:15:22]

http://codereview.chromium.org/7248058/diff/4001/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/7248058/diff/4001/src/profile-generator.cc#new...
src/profile-generator.cc:1903: TagObject(context->jsfunction_result_caches(),
"(context func caches)");
On 2011/06/30 13:45:27, Vitaly Repeshko wrote:
> nit: Maybe we should avoid abbreviations? The names are already quite
confusing.

Done.

http://codereview.chromium.org/7248058/diff/4001/src/profile-generator.cc#new...
src/profile-generator.cc:1916: objects_tags_.SetTag(map->instance_descriptors(),
"(map descriptors)");
On 2011/06/30 13:45:27, Vitaly Repeshko wrote:
> Use TagObject here?

Done.