Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 7248038: Profiles: Make NTPResourceCache a ProfileKeyedService. (Closed)

Created:
9 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 5 months ago
CC:
chromium-reviews, estade+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Profiles: Make NTPResourceCache a ProfileKeyedService. BUG=77155 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91049

Patch Set 1 #

Patch Set 2 : Oops. Missed the point. #

Total comments: 4

Patch Set 3 : Fix test compile #

Total comments: 1

Patch Set 4 : Add files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -37 lines) Patch
M chrome/browser/profiles/profile.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.h View 2 chunks +3 lines, -1 line 0 comments Download
A chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.cc View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
http://codereview.chromium.org/7248038/diff/2001/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (left): http://codereview.chromium.org/7248038/diff/2001/chrome/browser/profiles/profile_impl.cc#oldcode620 chrome/browser/profiles/profile_impl.cc:620: // Delete the NTP resource cache so we can ...
9 years, 5 months ago (2011-06-29 19:12:00 UTC) #1
Miranda Callahan
LGTM with a few changes -- looks like we crossed paths and you probably got ...
9 years, 5 months ago (2011-06-29 19:31:57 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-06-29 23:37:27 UTC) #3
Change committed as 91049

Powered by Google App Engine
This is Rietveld 408576698