Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 7248018: Fix the issue that a panel window cannot be shrink to very small (Closed)

Created:
9 years, 6 months ago by jianli
Modified:
9 years, 3 months ago
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

Fix the issue that a panel window cannot be shrink to very small. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99837

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M views/widget/native_widget_win.cc View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
jianli
9 years, 6 months ago (2011-06-23 19:57:05 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/7248018/diff/1/views/widget/native_widget_win.cc File views/widget/native_widget_win.cc (right): http://codereview.chromium.org/7248018/diff/1/views/widget/native_widget_win.cc#newcode2187 views/widget/native_widget_win.cc:2187: if (GetWidget()->frame_type() == Widget::FRAME_TYPE_FORCE_CUSTOM) { This is incorrect. Custom ...
9 years, 6 months ago (2011-06-23 20:48:55 UTC) #2
jianli
For the panel, the moving and sizing are all controlled by panel manager. From a ...
9 years, 6 months ago (2011-06-23 21:05:28 UTC) #3
Ben Goodger (Google)
What behavior are you trying to obtain? -Ben On Thu, Jun 23, 2011 at 2:05 ...
9 years, 6 months ago (2011-06-24 21:03:29 UTC) #4
jianli
We would like to change the height of the window to be as small as ...
9 years, 6 months ago (2011-06-24 22:02:44 UTC) #5
Ben Goodger (Google)
And yet you still want to provide a non-client view, correct? -Ben On Fri, Jun ...
9 years, 6 months ago (2011-06-24 22:06:27 UTC) #6
Ben Goodger (Google)
Does changing the handling of WM_GETMINMAXINFO help? -Ben On Fri, Jun 24, 2011 at 3:06 ...
9 years, 6 months ago (2011-06-24 22:06:57 UTC) #7
Peter Kasting
Shouldn't panels be all client area, and not have a nonclient portion? I agree that ...
9 years, 6 months ago (2011-06-24 22:08:43 UTC) #8
Ben Goodger (Google)
They have a caption... the title bar. -Ben On Fri, Jun 24, 2011 at 3:08 ...
9 years, 6 months ago (2011-06-24 22:09:41 UTC) #9
Peter Kasting
On 2011/06/24 22:09:41, Ben Goodger (Google) wrote: > They have a caption... the title bar. ...
9 years, 6 months ago (2011-06-24 22:11:16 UTC) #10
Ben Goodger (Google)
Think gmail chat moles, but on your desktop. They might even be (vertically?) resizable. The ...
9 years, 6 months ago (2011-06-24 22:12:35 UTC) #11
jianli
On Fri, Jun 24, 2011 at 3:06 PM, Ben Goodger (Google) <ben@chromium.org>wrote: > Does changing ...
9 years, 6 months ago (2011-06-24 22:24:52 UTC) #12
Ben Goodger (Google)
It may be worth making it possible for TYPE_POPUP windows to have a NonClientView. Currently ...
9 years, 6 months ago (2011-06-24 22:26:34 UTC) #13
jianli
Sounds like a good idea. But I do not want to interfere with all current ...
9 years, 6 months ago (2011-06-24 22:56:59 UTC) #14
Ben Goodger (Google)
We already NULL check the non-client view in places necessary to preserve that control path, ...
9 years, 6 months ago (2011-06-24 22:58:37 UTC) #15
jianli
Do you mean passing TYPE_POPUP from BrowserFrame::InitBrowserFrame to Widget::Init and creating NonClientView when we're creating ...
9 years, 5 months ago (2011-06-27 21:49:00 UTC) #16
Ben Goodger (Google)
I am suspicious of changing the style. I feel like there may be some unintended ...
9 years, 5 months ago (2011-06-27 21:51:54 UTC) #17
jianli
I just explored it with a sample win32 app and found out that we can ...
9 years, 5 months ago (2011-06-28 01:30:43 UTC) #18
Ben Goodger (Google)
On Mon, Jun 27, 2011 at 6:30 PM, Jian Li <jianli@chromium.org> wrote: > With further ...
9 years, 5 months ago (2011-06-28 20:59:42 UTC) #19
jianli
On Tue, Jun 28, 2011 at 1:59 PM, Ben Goodger (Google) <ben@chromium.org>wrote: > On Mon, ...
9 years, 5 months ago (2011-06-28 22:35:07 UTC) #20
Ben Goodger (Google)
This approach looks great to me. LGTM.
9 years, 5 months ago (2011-06-30 18:11:02 UTC) #21
Ben Goodger (Google)
9 years, 3 months ago (2011-08-31 23:46:59 UTC) #22
If this works, LGTM.

Powered by Google App Engine
This is Rietveld 408576698